Skip to content
This repository has been archived by the owner on Dec 3, 2022. It is now read-only.

Menu dropdown needs to work in header-right widget area #243

Open
remkus opened this issue Jun 18, 2014 · 4 comments
Open

Menu dropdown needs to work in header-right widget area #243

remkus opened this issue Jun 18, 2014 · 4 comments
Assignees
Milestone

Comments

@remkus
Copy link
Owner

remkus commented Jun 18, 2014

dropdown menus in header widget area are not displayed properly

@remkus remkus added the bug label Jun 18, 2014
@GaryJones GaryJones added this to the 1.0.0 milestone Jun 18, 2014
@GaryJones
Copy link
Contributor

This is actually a little more complex than it first seems.

For primary and secondary nav, we have a function that filters the building of it, to add in the mobile menu elements and sets a custom walker which handles the dropdown classes.

We need to tap into the output of the custom menu widget and do the same, but only if we're in the Header Right. However, that would then mean something like my Genesis Header Nav plugin wouldn't inherit the functionality, as it adds the menu to the same visual place, but outside of all of the Header Right widget area markup. Similarly, other nav menus that are added, we don't if they should be enhanced or not - we need to look at some attribute of wp_nav_menu to decide.

@remkus remkus added enhancement and removed bug labels Jun 18, 2014
@remkus
Copy link
Owner Author

remkus commented Jun 18, 2014

I'd be okay in not support plugins like Genesis Header Nav ... Let's see if you can find something relatively easy because I'm otherwise inclined to punt it to 1.1.0

GaryJones added a commit that referenced this issue Jun 18, 2014
Custom menu widget doesn't use custom walker yet, so doesn't have dropdown
classes applied etc.

See #243
@remkus
Copy link
Owner Author

remkus commented Jun 19, 2014

Let's not wrap a border around menu items when they're in the header widget. Looks clunky...

@GaryJones
Copy link
Contributor

Problem still exists re dropdowns.

Suggest punting to 1.1.0

@GaryJones GaryJones assigned remkus and unassigned GaryJones Jul 9, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants