Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SIGHUP example in docs with one that doesn't assume arcane Unix knowledge #1246

Open
njsmith opened this issue Oct 13, 2019 · 0 comments · May be fixed by #1281
Open

Replace SIGHUP example in docs with one that doesn't assume arcane Unix knowledge #1246

njsmith opened this issue Oct 13, 2019 · 0 comments · May be fixed by #1281
Labels

Comments

@njsmith
Copy link
Member

njsmith commented Oct 13, 2019

Currently in our docs for open_signal_receiver, we have an example of catching SIGHUP and using it to reload the application configuration. While talking to @wgwz today re: python-trio/snekomatic#41, I discovered that this example is maybe not so great, because readers who aren't already steeped in Unix traditions will have no idea what the heck a SIGHUP is supposed to be.

Using SIGTERM in the example would probably be less distracting!

@njsmith njsmith added the docs label Oct 13, 2019
@jmfrank63 jmfrank63 linked a pull request Nov 2, 2019 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant