Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gh-action-sigstore-python from the GitHub Actions publishing guide #1788

Open
1 task done
woodruffw opened this issue Jan 15, 2025 · 0 comments
Open
1 task done

Comments

@woodruffw
Copy link
Member

Issue Description

I'm filing this as a reminder issue for myself, although if someone wants to get to it before I do please feel free 🙂

TL;DR: The current GitHub Actions publishing guide has sections like this that reference gh-action-sigstore-python for signing. This step is strictly superfluous now that PEP 740 has been implemented on PyPI, since the publishing step (or more generally, any step that chooses to make an attestation) does the signing implicitly.

As such, references to gh-action-sigstore-python should probably be fully removed and replaced with notes about how attestations currently work by default when using a supported Trusted Publishing provider (currently GitHub and GitLab, but others as well in the future). Keeping the references in place is liable to cause user confusion:

  1. The signatures produces by gh-action-sigstore-python aren't format-compatible with what PEP 740 expects, meaning they really only end up in the GitHub release artifacts, where they have limited value;
  2. Having two+ signing steps means the user ends up with multiple sets of signatures per artifact, which is confusing.

Neither of these results in breakage, but we can eliminate them as sources of confusion 🙂

Code of Conduct

  • I am aware that participants in this repository must follow the PSF Code of Conduct.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant