Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vasprun parser doesn't parse everything that is intended #1226

Open
pmrv opened this issue Nov 29, 2023 · 0 comments · May be fixed by #1272
Open

Vasprun parser doesn't parse everything that is intended #1226

pmrv opened this issue Nov 29, 2023 · 0 comments · May be fixed by #1272
Labels
bug Something isn't working

Comments

@pmrv
Copy link
Contributor

pmrv commented Nov 29, 2023

if leaf.tag in ["generator", "incar"]:

This line makes it appear that we actually want to parse most meta data from a vasprun.xml file (version, date, etc.), but this conditional is never hit because leaf.tag is never, e.g. 'generator'. I think the reason is probably because elementtree.iterparse seems to return xml elements depth first, i.e. leaf iterates over the tags inside <generator> but not that tag itself, but I don't have time to debug this in depth.

@pmrv pmrv added the bug Something isn't working label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant