Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonSpec preserveZeroDecimal=true tests fail regularly #1119

Open
pjfanning opened this issue Jan 6, 2025 · 0 comments
Open

JsonSpec preserveZeroDecimal=true tests fail regularly #1119

pjfanning opened this issue Jan 6, 2025 · 0 comments

Comments

@pjfanning
Copy link
Contributor

Are you looking for help?

This is an issue tracker, used to manage and track the development of Play JSON. It is not a support system and so it is not a place to ask questions or get help. If you're not sure if you have found a bug, the best place to start is with either the Play Discussion Forum or Stack Overflow.

If you want to discuss a feature request, the same tools are available.

Play JSON Version (2.5.x / etc)

Latest main branch.

API (Scala / Java / Neither / Both)

Operating System (Ubuntu 15.10 / MacOS 10.10 / Windows 10)

Use uname -a if on Linux.

Observed in Mac and GitHub CI builds.

JDK (Oracle 1.8.0_72, OpenJDK 1.8.x, Azul Zing)

Paste the output from java -version at the command line.

Java 17

Library Dependencies

If this is an issue that involves integration with another system, include the exact version and OS of the other system, including any intermediate drivers or APIs i.e. if you connect to a PostgreSQL database, include both the version / OS of PostgreSQL and the JDBC driver version used to connect to the database.

Expected Behavior

Please describe the expected behavior of the issue, starting from the first action.

  1. JsonSpec should pass

Actual Behavior

Please provide a description of what actually happens, working from the same starting point.

Be descriptive: "it doesn't work" does not describe what the behavior actually is -- instead, say "the page renders a 500 error code with no body content." Copy and paste logs, and include any URLs. Turn on internal Play JSON logging with <logger name="play" value="TRACE"/> if there is no log output.

Example:

       x preserve a single trailing zero decimal from zero decimal with preserveZeroDecimal=true (14 ms)
[error]        '0' != '0.0' (JsonSpec.scala:357)

Usually pass but intermittently one or other (not always the same one) will fail because the actual result does not preserve the trailing .0.

One example run:
https://github.com/playframework/play-json/actions/runs/11864258666/job/33067682099

Reproducible Test Case

Please provide a PR with a failing test.

If the issue is more complex or requires configuration, please provide a link to a project on Github that reproduces the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant