-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
+pkgm #8419
base: main
Are you sure you want to change the base?
Conversation
@mxcl odd. i wonder if this is because both v1 and v2 are present? ▌ pantry script start
+ cd /Users/jacob/pkgx/pantry/testbeds/pkgx.sh__pkgm-0.3.0
+ pkgm --version
pkgm 0.3.0
+ pkgm install dua
┏ ⚠️ Deno requests run access to "pkgx".
┠─ Requested by `Deno.Command().spawn()` API.
┠─ To see a stack trace for this prompt, set the DENO_TRACE_PERMISSIONS environmental variable.
┠─ Learn more at: https://docs.deno.com/go/--allow-run
┠─ Run again with --allow-run to bypass this prompt.
┗ Allow? [y/n/A] (y = yes, allow; n = no, deny; A = allow all run permissions) > ^local. on CI it just fails. |
adding: - sed -i 's|--allow-run=pkgx,/usr/bin/sudo|--allow-run|' pkgm "fixes" that, but then i get: ▌ pantry script start
+ cd /Users/jacob/pkgx/pantry/testbeds/pkgx.sh__pkgm-0.3.0
++ pkgm --version
+ test 'pkgm 0.3.0' = 'pkgm 0.3.0'
+ pkgm install dua
× usage error: no such arg: --json
error: Uncaught (in promise) Error: UR TEST FAILED WITH CODE 1 & SIGNAL null
if (!rv.success) throw new Error(`UR TEST FAILED WITH CODE ${rv.code} & SIGNAL ${rv.signal}`)
^
at file:///Users/jacob/.pkgx/pkgx.sh/brewkit/v1.14.3/bin/bk-test:106:24
at eventLoopTick (ext:core/01_core.js:182:7) which means it's finding v1 first. so... maybe this can't be done until we move brewkit to v2? |
Maybe we should |
possibly, but a) deno compile binaries are huge, and b) it requires pkgx to functional in any case. |
I see. Maybe you should remove |
there's a bug somewhere if it finds v1 when the package depends on v2. |
a612c55
to
91bec03
Compare
that's... what it seems like, even though path inspection shows v2. and the darwin version gets |
What's the benefit of keeping pkgx in the dependencies list? It would trigger pkgx to redundantly install another pkgx. Also, if users installed pkgx in their machine, they would expect pkgm to reuse that installation. It doesn't make sense to break that expectation, does it? |
it strictly requires pkgx^2. and may, in the future, strictly require higher versions. so, same benefits of mapping dependencies. |
Regardless of which version of pkgx pkgm requires, I would expect pkgm to use the version of pkgx which I installed to my system, even if it is not compatible and fails. Maybe pkgm should be an exception, as it manages stuff installed at system level, not at pkgx dir level. Well, maybe I'm going too crazy. lol |
Maybe this is like |
Maybe my concern will be "fixed" by: pkgxdev/pkgx#971 (comment) I.e. would allow my system installed pkgx to satisfy the (companion) dependency. |
closes #8405