Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api(cdc): fix create changefeed after scale-in pd #12003

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

api(cdc): fix create changefeed after scale-in pd #12003

wants to merge 7 commits into from
+125 −86

Conversation

lidezhu
Copy link
Collaborator

@lidezhu lidezhu commented Jan 15, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #12004

What is changed and how it works?

When the api request doesn't contain any pd address, use the default upstream of the capture.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
  1. Deploy a cluster with 3 pds;
  2. Scale out 3 new pds;
  3. Transfer pd leader;
  4. Scale in 3 old pds;
  5. Create changefeed;

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

Fix create changefeed after scale in pds in some scenarios.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 15, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lidezhu and additionally assign yudongusa for approval(Please ensuring that each of them provides their approval before proceeding). For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue do-not-merge/needs-triage-completed labels Jan 15, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.40909% with 19 lines in your changes missing coverage. Please review.

Project coverage is 55.2639%. Comparing base (fa5baad) to head (bc53da5).

✅ All tests successful. No failed tests found.

Additional details and impacted files
Components Coverage Δ
cdc 59.6900% <78.4090%> (-0.0391%) ⬇️
dm 50.1286% <ø> (-0.0154%) ⬇️
engine 53.2223% <ø> (+0.0282%) ⬆️
Flag Coverage Δ
unit 55.2639% <78.4090%> (-0.0162%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #12003        +/-   ##
================================================
- Coverage   55.2801%   55.2639%   -0.0162%     
================================================
  Files          1028       1028                
  Lines        142724     142735        +11     
================================================
- Hits          78898      78881        -17     
- Misses        58052      58077        +25     
- Partials       5774       5777         +3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen Awaiting requested review from asddongmen

@hongyunyan hongyunyan Awaiting requested review from hongyunyan

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to create changefeed after scale-in pd
1 participant
@lidezhu