Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: List approved packages and functions in yaml file #199

Open
thomas-neitmann opened this issue Aug 11, 2023 · 5 comments
Open
Labels
enhancement New feature or request

Comments

@thomas-neitmann
Copy link

Feature Idea

I really like the feature of logging use of Unapproved Packages and Functions. Rather than creating a list within R and saving it as a .rds file, though, I'd like to store this information in something like a yaml file, e.g.

base: "all"
dplyr: ["mutate", "filter", "summarize"]
ggplot2: "all"

Then you could have the option point to that yaml file instead. The existing functionality could stay as is. This would just be another option of specifying the same information.

Relevant Input

No response

Relevant Output

No response

Reproducible Example/Pseudo Code

No response

@thomas-neitmann thomas-neitmann added the enhancement New feature or request label Aug 11, 2023
@thomas-neitmann thomas-neitmann changed the title Feature Request: <Insert Issue Title Here> Feature Request: List approved package and function in yaml file Aug 11, 2023
@thomas-neitmann thomas-neitmann changed the title Feature Request: List approved package and function in yaml file Feature Request: List approved packages and functions in yaml file Aug 11, 2023
@thomas-neitmann
Copy link
Author

thomas-neitmann commented Aug 11, 2023

As a side note, the keyword to specify that all functions from a package should be used should be something that is not a valid R function name. "All" is and is thus ambiguous. Function names cannot start with an underscore so how about "_all" instead?

@nicolekjones
Copy link

I'd be happy to work on implementing this feature!

@bms63
Copy link
Collaborator

bms63 commented Aug 11, 2023

@pharmaverse/logrx what do you all think?

@nicholas-masel
Copy link
Collaborator

nicholas-masel commented Aug 21, 2023

I'd be happy to work on implementing this feature!

@nicolekjones We're all for it! Please do go ahead with this feature and throw in a PR. Our only request is the rds still functions as is and yaml is added as an additional feature for both read and write.

@nicolekjones
Copy link

I'd be happy to work on implementing this feature!

@nicolekjones We're all for it! Please do go ahead with this feature and throw in a PR. Our only request is the rds still functions as is and yaml is added as an additional feature for both read and write.

Will do! PR to come 😄

@bms63 bms63 moved this to 📋 Backlog in logrx 0.3.0 Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 📋 Backlog
Development

No branches or pull requests

4 participants