Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - [Tabs] - [Vertical Tabs show content below tablist instead of beside] #9869

Open
carlosthe19916 opened this issue Dec 7, 2023 · 4 comments

Comments

@carlosthe19916
Copy link

Describe the problem
When using vertical tabs, the content is rendered below the tablist.
This looks a bit strange, especially when using boxed tabs.

How do you reproduce the problem?
This behavior is shown on the Patternfly website: https://www.patternfly.org/components/tabs#vertical-tabs:
288537127-536b0c86-003d-47a4-9b49-18848fece0a4

Note that the tablist fills the entire width of the demo.

So you can use the code from that example

Expected behavior
The content is displayed to the right of the tablist, as the design (especially if the tabs are boxed) indicates.

I could sort of replicate what I want by wrapping both the tablist and the content in a flexbox.

<div class="pf-v5-c-tabs pf-m-vertical pf-m-box">
  <div style="display: flex;">
    <ul class="pf-v5-c-tabs__list">...</ul>
    <section class="pf-v5-c-tab-content">Users</section>
  </div>
</div>

yields:

288542503-b60707b4-729b-41ef-824f-a785343c2e3a

Is this issue blocking you?
The current workaround is to use detached tabs and place the tabs and the content in a grid and manually specifying how large each side should be.

Screenshots
If applicable, add screenshots to help explain the issue.

What is your environment?

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

What is your product and what release date are you targeting?

OS: Arch Linux
Browser: Firefox

This is a copy of the original issue patternfly/patternfly#6117 and I moved here since I believe it fits more the ReactJS library rather than the Patternfly repo itself.

@tlabaj
Copy link
Contributor

tlabaj commented Jan 25, 2024

cc @andrew-ronaldson

@wise-king-sullyman wise-king-sullyman moved this from Needs triage to Backlog in PatternFly Issues Jan 30, 2024
@wise-king-sullyman
Copy link
Contributor

Thanks for making this issue!

The PF leads believe this is operating as intended from a React standpoint, but that we should create a demo of vertical tabs in a sidebar once patternfly/patternfly#6117 and any associated followup work is complete.

Copy link

stale bot commented Apr 11, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Apr 11, 2024
Copy link

false

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 25, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in PatternFly Issues Apr 25, 2024
@tlabaj tlabaj added Pinned and removed wontfix labels Apr 25, 2024
@tlabaj tlabaj reopened this Apr 25, 2024
@github-project-automation github-project-automation bot moved this from Done to Needs triage in PatternFly Issues Apr 25, 2024
@tlabaj tlabaj added the bug label May 2, 2024
@tlabaj tlabaj moved this from Needs triage to Backlog in PatternFly Issues May 2, 2024
@kmcfaul kmcfaul removed the bug label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

4 participants