Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav - add wrapper to Nav link item text by default #9755

Closed
tlabaj opened this issue Oct 17, 2023 · 2 comments · Fixed by #10687
Closed

Nav - add wrapper to Nav link item text by default #9755

tlabaj opened this issue Oct 17, 2023 · 2 comments · Fixed by #10687
Assignees
Labels
Breaking change 💥 this change requires a major release and has API changes.

Comments

@tlabaj
Copy link
Contributor

tlabaj commented Oct 17, 2023

Describe the enhancement or change
A clear and concise description of the request. What is the expected outcome?

Update NavItem to add the Nav link text wrapper (.pf-v5-c-nav__link-text) by default instead of as an opt-in. Remove the hasNavLinkWrapper opt-in prop.

@tlabaj tlabaj added Breaking change 💥 this change requires a major release and has API changes. DevX labels Oct 17, 2023
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Oct 17, 2023
@wise-king-sullyman wise-king-sullyman moved this from Needs triage to Backlog in PatternFly Issues Oct 17, 2023
@thatblindgeye
Copy link
Contributor

In addition to the above, as part of the work from patternfly/patternfly#6704 (review) we will need to add a prop for an icon that must be rendered before the link text.

@mcoker
Copy link
Contributor

mcoker commented May 29, 2024

This should be ready to work on now, work was done in patternfly/patternfly#6704. And as @thatblindgeye mentioned in #9755 (comment), there is a separate enhancement (that depends on the nav text wrapper) to add icon support to nav items. Not sure if we want a separate issue for that, or just include it as part of this update @tlabaj?

@tlabaj tlabaj moved this from Backlog to On deck in PatternFly Issues Jun 11, 2024
@tlabaj tlabaj added this to the Penta beta release milestone Jun 11, 2024
@tlabaj tlabaj added the PF6 label Jun 11, 2024
@kmcfaul kmcfaul moved this from On deck to Not started in PatternFly Issues Jun 18, 2024
@nicolethoen nicolethoen moved this from Not started to In Progress in PatternFly Issues Jul 1, 2024
@nicolethoen nicolethoen moved this from In Progress to PR Review in PatternFly Issues Jul 2, 2024
@kmcfaul kmcfaul closed this as completed Jul 15, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change 💥 this change requires a major release and has API changes.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants