Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: "component" prop audit #8958

Closed
tlabaj opened this issue Apr 14, 2023 · 1 comment
Closed

chore: "component" prop audit #8958

tlabaj opened this issue Apr 14, 2023 · 1 comment
Labels

Comments

@tlabaj
Copy link
Contributor

tlabaj commented Apr 14, 2023

Is this a new component or an extension of an existing one?
What is the existing component, if any?
We should audit the use of the component prop in our code base. In some place it is intended for use as any ReactElement. In some place it is specific React elements that are allowed to be used. In some places THe intended use is to support a React router (or other library) "Link".
We should audit the component props to determine if the types a re accurate for the intended use case. WE should determine if the types should change to be more specific to the use case.

This issue is related to discusion and investigation done for issue: #6115

Copy link

stale bot commented Nov 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Nov 7, 2023
@stale stale bot closed this as completed Nov 22, 2023
@github-project-automation github-project-automation bot moved this from Not started to Done in PatternFly Issues Nov 22, 2023
@tlabaj tlabaj removed this from the Prioritized Backlog milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

2 participants