Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike: Revisit Timestamp accessibility #10265

Open
thatblindgeye opened this issue Apr 9, 2024 · 1 comment
Open

Spike: Revisit Timestamp accessibility #10265

thatblindgeye opened this issue Apr 9, 2024 · 1 comment
Labels

Comments

@thatblindgeye
Copy link
Contributor

thatblindgeye commented Apr 9, 2024

Describe the enhancement or change
Per a discussion including @jgiardino and @jessiehuff there are some issues related to accessibility with our current Timestamp implementation:

  • There's no clear visual indication that the timestamp text can be interacted with when there's a tooltip
  • The tooltip content does not get announced by AT when triggered

Some ideas that have been brought up to help resolve this include:

  • Render screen reader text in the timestamp wrapper element of the UTC (or whatever other) time, and render the full timestamp info in the tooltip. Essentially treating the timestamp as truncated content when there's a tooltip. This would require rendering the UTC/additional time in a time element and passing it a valid datetime attribute (we're already handling this in a way if no dateTime prop is passed to Timestamp, so we could just expose a new "tooltipDateTime" prop or something if a user wants/needs to pass their own datetime attribute). See the following video for an example (note that VO is not announcing the tooltip content, it is announcing the visible text + screen reader text that is also wrapped in the main timestamp span wrapper).

    Timestamp.with.truncation.example.mov
  • Rendering an icon button next to the main timestamp visual text, and apply a popover (instead of a tooltip) to that button. This would require rendering a time element inside the popover as well if users can navigate into the popover.

For both points above, we already handle creating a datetime attribute internally if a consumer doesn't pass their own dateTime prop:

<time className={`${styles.timestamp}__text`} dateTime={dateTime || new Date(date).toISOString()}>

Which just creates a string of the UTC time already which should be valid.

Is this request originating from a Red Hat product team? If so, which ones and is there any sort of deadline for this enhancement?

Any other information?

@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Apr 9, 2024
@tlabaj tlabaj moved this from Needs triage to Backlog in PatternFly Issues Apr 18, 2024
@tlabaj tlabaj added this to the Prioritized Backlog milestone Apr 18, 2024
@kmcfaul kmcfaul removed the Tech debt label Oct 25, 2024
@kywalker-rh
Copy link

@thatblindgeye Is there something we can do from the RHOAI team to push this forward? Until we get this fixed we're using UTC time most places (we're a little inconsistent, but that's the recommendation) but personally I find that generally undesirable since its very hard for me to convert UTC time into my local time. It would be far better if it was just converted for me by default and there was an accessible way to see the UTC time if relevant.

@tlabaj tlabaj removed this from the Prioritized Backlog milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

4 participants