Unify recover fn result type

[mattsse]

Describe the feature

we only recently introduced RecoveryErr

reth/crates/primitives-traits/src/transaction/signed.rs

Line 87 in 21761ad

fn try_recover_unchecked(&self) -> Result<Address, RecoveryError> {

but kept the function that return an option

reth/crates/primitives-traits/src/transaction/signed.rs

Line 79 in 21761ad

fn recover_signer_unchecked(&self) -> Option<Address> {

reth/crates/primitives-traits/src/transaction/signed.rs

Line 65 in 21761ad

fn recover_signer(&self) -> Option<Address>;

TODO

• replace Option<Address> with Result<Address, RecoveryErr>

update error handling, such as:

reth/crates/rpc/rpc-eth-types/src/receipt.rs

Line 25 in 21761ad

transaction.recover_signer_unchecked().ok_or(EthApiError::InvalidTransactionSignature)?;

which can then use the ? operator if we add a From<RecoveryErr> impl for EthApiError for example

Additional context

No response

[hoank101]

hi sir, i can do it