Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(trie): hash recalculation on updates retention disabled #13834

Open
rkrasiuk opened this issue Jan 16, 2025 · 0 comments
Open

bug(trie): hash recalculation on updates retention disabled #13834

rkrasiuk opened this issue Jan 16, 2025 · 0 comments
Assignees
@shekhirin
Labels
A-trie Related to Merkle Patricia Trie implementation C-bug An unexpected or incorrect behavior

Comments

@rkrasiuk
Copy link
Member

Description

The use of precomputed hash should not depend on store_in_db_trie var.

reth/crates/trie/sparse/src/trie.rs

Lines 674 to 676 in 3212af2

if let Some((hash, store_in_db_trie)) =
hash.zip(*store_in_db_trie).filter(|_| !prefix_set_contains(&path))
{

@rkrasiuk rkrasiuk added A-trie Related to Merkle Patricia Trie implementation C-bug An unexpected or incorrect behavior labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shekhirin shekhirin

Labels
A-trie Related to Merkle Patricia Trie implementation C-bug An unexpected or incorrect behavior
Projects
Reth Tracker
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shekhirin @rkrasiuk