-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EngineApiBuilder
to RpcAddons
#13831
Comments
if we need to modify engine api then this should become part of the launch logic I think |
not sure I follow? rn this trait isn't used, implementing this issue would make way for using it |
@emhane isn't this trait only relevant for alloy provider and not reth rpc? i.e op-node would still expect eth-compatible engine API |
@cody-wang-cb are you keen on this to unblock ethereum-optimism/pm#20 |
unclear what this is issue is about tbh what's the usecase here |
actually op Engine API shouldn't support v1 requests, it breaks spec. eventually we want to use the |
Describe the feature
Define
EngineApiBuilder
and add toRpcAddons
. Follow how it has been done forEthApiBuilder
andEngineValidator
reth/crates/node/builder/src/rpc.rs
Lines 338 to 341 in 7e972ea
Then, instead of calling
EngineApi
constructor here, callEngineApiBuilder::build
reth/crates/node/builder/src/rpc.rs
Lines 435 to 445 in 7e972ea
Additional context
No response
The text was updated successfully, but these errors were encountered: