Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm install error, and raven-agent-config is lost. #101

Closed
arctan90 opened this issue Apr 3, 2023 · 2 comments · Fixed by #102
Closed

Helm install error, and raven-agent-config is lost. #101

arctan90 opened this issue Apr 3, 2023 · 2 comments · Fixed by #102
Labels
bug Something isn't working

Comments

@arctan90
Copy link
Contributor

arctan90 commented Apr 3, 2023

forward-node-ip: {{ .Values.vpn.forwardNodeIP }}


error msg

Error from server (BadRequest): error when creating "cm.yaml": ConfigMap in version "v1" cannot be handled as a ConfigMap: v1.ConfigMap.Data: ReadString: expects " or n, but found f, error found in #10 byte of ...|node-ip":false,"vpn-|..., bigger context ...|{"apiVersion":"v1","data":{"forward-node-ip":false,"vpn-driver":"libreswan"},"kind":"ConfigMap",|...

reason

Run helm template comes to

# Source: raven-agent/templates/config.yaml
apiVersion: v1
data:
  vpn-driver: libreswan
  forward-node-ip: false
kind: ConfigMap
metadata:
  name: raven-agent-config
  namespace: kube-system

the forward-node-ip: false should be forward-node-ip: "false"

Suggestion

using quote in helm chart, and maybe some change in operator for this configuration.
forward-node-ip: {{ .Values.vpn.forwardNodeIP | quote }}

@njucjc
Copy link
Member

njucjc commented Apr 3, 2023

@arctan90 Could you open a PR to fix this problem?

@njucjc njucjc pinned this issue Apr 3, 2023
@njucjc njucjc unpinned this issue Apr 3, 2023
@njucjc njucjc added the bug Something isn't working label Apr 3, 2023
@arctan90
Copy link
Contributor Author

arctan90 commented Apr 3, 2023

@arctan90 Could you open a PR to fix this problem?

my pleasure.

arctan90 pushed a commit to arctan90/openyurt_raven that referenced this issue Apr 3, 2023
njucjc added a commit that referenced this issue Apr 3, 2023
@njucjc njucjc closed this as completed Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants