Call --john show when m_johnPath change

[mathsoft-dev]

Since different johns have different .pot file, I think we should at least call john --show when user change m_johnPath.
example : my core john path has empty .pot, if I switch to my jumbo one with has a lot of md5 pwd, the progress bar isn't updated, default format too and I still see no pwd in the tableview

[shinnok]

Well when john path changes(to a valid one of course) we need to:

1. Reconsider UI based on core vs. jumbo
2. Start a new session just like open file
3. Call john show as usual

The only aspect that remains unchanged is the password file selection.

[mathsoft-dev]

Well when john path changes(to a valid one of course) we need to:

1. Reconsider UI based on core vs. jumbo
2. Start a new session just like open file
3. Call john show as usual

The only aspect that remains unchanged is the password file selection.

1. Reconsider UI based on core vs. jumbo has been done for a while. 3 is done in 4a7046c. 2 isn't.

What should we do for 2., there isn't anything related to john executable in JohnSession as of now, the two sessions will be the same. Call the copy constructor ?
JohnSession session2 = session1 ; m_sessionCurrent = session2;
I don't really see what i'd change for now ..

Edit: Do you mean that some version of john can't read .rec from other version and you want to prevent resuming attack by creating a new session with a different name ?

[shinnok]

A session created with jumbo and specific options/attacks won't be useful anymore if the user changes the John path to a core version, which is a totally valid and expected use case scenario.

That's why we should start a new session with options reset. Basically just call MainWindow::readPasswdFiles() again with the same input files.

[shinnok]

Are you clear on what you need to do for this?

[shinnok]

Is this handled?

[mathsoft-dev]

I'm still trying to figure out what you mean but I focus most of my time on other issues like *2john and the others so it does not progress

[shinnok]

If you find it too much for the time being, move it to the next milestone, it's not an urgency. :-)

[shinnok]

Moved to the next milestone. Let's get v2.2 out the door.