Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add origin definition in terminology #382

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

timcappalli
Copy link
Member

Closes #379

Adds definition for origin under terminology

@timcappalli
Copy link
Member Author

@awoie (or anyone else who knows) how do you do an "inline" reference to a term already defined in the doc in Kramdown?

In Bikeshed / Respec, you define the term <dfn>term name</dfn> and then when you use that term later on, you use [=term name=] which automatically links back to the definition under the terminology section.

@awoie
Copy link
Contributor

awoie commented Jan 14, 2025

Suggested some more changes in this PR #383

@@ -101,6 +101,11 @@ Holder Binding:
Issuer-Holder-Verifier Model:
: A model for exchanging claims, where claims are issued in the form of Verifiable Credentials independent of the process of presenting them as Verifiable Presentation to the Verifiers. An issued Verifiable Credential can (but must not necessarily) be used multiple times.

Origin:
: An identifier for the calling website or native application, asserted by the web or app platform. A web origin is the combination of a scheme/protocol, host, and port, with port being omitted when it matches the default port of the scheme. An app platform may use a linked web origin, or use a platform-specific URI for the app origin.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking of an offline Relying party using DCAPI with hybrid over Bluetooth, is the current definition too narrow? We may also change the definition once we get there though

2 approvals. merging since this impacts another PR
Copy link
Contributor

@awoie awoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since my suggestions #383 were merged into this.

@awoie
Copy link
Contributor

awoie commented Jan 16, 2025

@awoie (or anyone else who knows) how do you do an "inline" reference to a term already defined in the doc in Kramdown?

In Bikeshed / Respec, you define the term <dfn>term name</dfn> and then when you use that term later on, you use [=term name=] which automatically links back to the definition under the terminology section.

No, I don't as mentioned in #383 but mentioning again just in case my comment got lost. I don't think this was done in any OIDF spec, at least it wasn't done in OIDC core or OID4VC-related specs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make "origin" a formal definition in VP that can be referenced throughout
5 participants