-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add intent to retain to claims query in DCQL #338
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not in favor of adding this and I think there have been good reasons/argumentations in the Issue. In short, the feature as-is is under-specified and likely of not much use and it seems more reasonable to convey this via the purpose
field.
WG discussion: agreement that this is not perfect (PR text should be improved), but probably good enough as a starting point to meet the requirements and have a transition path for those who us intent_to_retain in 18013-5/PE. |
A potential issue I see is that if this option is added in this form it will probably need to be maintained in the version it is introduced as it could be a breaking change to remove it. (maybe a parallel mechanism can be introduced that could be marked as preferred in 1.1? something like PEX vs DCQL) Other than that if the group is short on time and this option is required it may be a good compromise until a better mechanism is found. |
the feature is another option I considered when doing PR is to add intent_to_retain only to mdocs, but that did not feel in sprit of the specification, or the discussions we have been having.. |
@@ -744,6 +744,9 @@ within the Verifiable Credential, as defined in (#claims_path_pointer). | |||
If the `values` property is present, the Wallet SHOULD return the claim only if the | |||
type and value of the claim both match for at least one of the elements in the array. Details of the processing rules are defined in (#selecting_claims). | |||
|
|||
`intent_to_retain` | |||
: OPTIONAL. A boolean that indicates the Verifier intends to store the Claim's data that is being requested beyond the processing of the response. For example, to meet regulatory requirements of retaining records of transactions or to maintain user profiles. If omitted, the default value is `false`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
: OPTIONAL. A boolean that indicates the Verifier intends to store the Claim's data that is being requested beyond the processing of the response. For example, to meet regulatory requirements of retaining records of transactions or to maintain user profiles. If omitted, the default value is `false`. | |
: OPTIONAL. A boolean that indicates the Verifier intends to store the Claim's data that is being requested beyond the processing of the response. For example, to inform the holder what happens to the data after it is released. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`+ move it to the mdoc section as a starting point. and for the definition, point to ISO 18013-5 section X
resolves #321