Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_Exception: Exception: Failed to load SVG: https://static.openfoodfacts.org/images/attributes/ecoscore-c.svg 404 #4940

Open
sentry-io bot opened this issue Jan 1, 2024 · 11 comments · Fixed by #4942

Comments

@sentry-io
Copy link

sentry-io bot commented Jan 1, 2024

Sentry Issue: SMOOTHIE-39J

_Exception: Exception: Failed to load SVG: https://static.openfoodfacts.org/images/attributes/ecoscore-c.svg 404
@monsieurtanuki
Copy link
Contributor

Of course it's a temporary issue; in the long run the products will be refreshed and point to the new web "dist" folder (e.g. https://static.openfoodfacts.org/images/attributes/dist/ecoscore-c.svg)
Meanwhile, it's the top Sentry issue and caused 152K errors this week...

@teolemon
Copy link
Member

teolemon commented Jan 1, 2024

We need to sort out the refresh scenario.

  1. There's been the language change issue for a while (mostly happens to me when I demo the app) The app should offer to reload all products on language change #1651
  2. I'm not clear if we refresh systematically on opening the full product page (I believe we should, especially as the structure of the knowledge panel evolves)
  3. That is going to be all the more pressing that we're going to have the new Nutri-Score soon (March/April?).
    https://www.francetvinfo.fr/replay-radio/le-billet-vert/alimentation-les-regles-du-nutri-score-evoluent_6246153.html
  • Nutri-Score: We'll need a team brainstorm to find how we want to showcase the change in the app.
    • Do nothing
    • Refresh (silently or not) all products from all installs in a way that is compatible with the server not being overwhelmed ?
    • Refresh (silently or not) on opening the product ?
    • Refresh manually with a promotion like: "The new Nutri-Score formula is here. Tap to refresh the score for all products you have ever scanned."

@monsieurtanuki
Copy link
Contributor

About to PR something focused on "images moved to the dist web folder".
The other more important questions are to be dealt with in #4941.

@teolemon
Copy link
Member

@monsieurtanuki
Copy link
Contributor

Exception: Failed to load SVG: https://static.openfoodfacts.org/images/attributes/dist/nutriscore--new-en.svg 404

It's normal: the file doesn't exist, because there's no note. Compared to https://static.openfoodfacts.org/images/attributes/dist/nutriscore-a-new-en.svg
Which barcode?

@teolemon
Copy link
Member

@monsieurtanuki
Copy link
Contributor

I can see the old nutriscore in the app.
I don't remember the tap dancing needed in order to display the new nutriscore.

@monsieurtanuki
Copy link
Contributor

Top 2 sentry error this week.
Latest example:

Exception: Failed to load SVG: https://static.openfoodfacts.org/images/attributes/dist/green-score-.svg 404

@monsieurtanuki
Copy link
Contributor

Top 1 sentry error this week.

@teolemon
Copy link
Member

teolemon commented Jan 4, 2025

I have files a server-side issue @monsieurtanuki

@teolemon
Copy link
Member

teolemon commented Jan 4, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants