Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the "clear / X" button #4233

Closed
teolemon opened this issue Jun 25, 2023 · 2 comments
Closed

Refactor the "clear / X" button #4233

teolemon opened this issue Jun 25, 2023 · 2 comments

Comments

@teolemon
Copy link
Member

Screenshot_20230625-102411.png

Originally posted by @teolemon in #4232 (comment)

Screenshot_20230625-163346.png

@monsieurtanuki monsieurtanuki changed the title ![Screenshot_20230625-102411.png](https://github.com/openfoodfacts/smooth-app/assets/1689815/27cb0f4d-a457-443f-8810-f3c24dc4f67e) Refactor the "clear / X" button Jun 25, 2023
@g123k
Copy link
Collaborator

g123k commented Jun 25, 2023

Why not, but why is the cross button using rounded corners, whereas the plus doesn't?
And also, why isn't the plus icon not circled also?

@teolemon
Copy link
Member Author

@monsieurtanuki @g123k
The positioning is not right. I was wondering whether we could overlay it above the card, on the very top right, with some of it outside the card.
This would free up a lot of real estate to do a better layout within the card (eg more text, more visuals…)

@github-actions github-actions bot added the ⭐ top issue Top issue. label Jun 25, 2023
@g123k g123k closed this as completed Jan 16, 2025
@github-project-automation github-project-automation bot moved this from 💬 To discuss and validate to 🎊 Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants