Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and improve section for adding nutrient values #9325

Open
zanovis opened this issue Apr 4, 2023 · 1 comment
Open

Simplify and improve section for adding nutrient values #9325

zanovis opened this issue Apr 4, 2023 · 1 comment

Comments

@zanovis
Copy link

zanovis commented Apr 4, 2023

Problem

The Edit Nutrients section is a bit overwhelming for new users and leads to some confusion due to values not translating if toggles are changed.

Proposed solution

  1. Is there value in having a distinction between 'Nutrition as sold' vs 'Nutrition for prepared product'? If not, I suggest removing the option to select one or the other to reduce friction. I imagine most products list nutrition 'as sold'.

  2. Can we use defaults in the nutrition fields to the user's region defaults? So for US users, the default would be 'per serving' (Similar to: User Preference for 'per 100g' vs 'per serving' toggle smooth-app#3615). I believe we are taking in US 'per serving' values, and normalizing to 'per 100g'. How is this being calculated if the product doesn't have 'serving size' nor 'product_quantity'? In the EU, I think this would remain 'per 100g'.

  3. Can we translate the values from 'per 100g' values to 'per serving' values if the radio button is switched? Currently, it does not translate.

Mockups

Not exactly like this, but to give you an idea:
image

Part of

openfoodfacts/smooth-app#3615

@CharlesNepote
Copy link
Member

CharlesNepote commented Apr 5, 2023

  1. Is there value in having a distinction between 'Nutrition as sold' vs 'Nutrition for prepared product'? If not, I suggest removing the option to select one or the other to reduce friction. I imagine most products list nutrition 'as sold'.

Yes there is value to do this because:

A solution could be to remove [ ] for 100 g / 100 ml [x] per serving when Nutrition for prepared product is unchecked.

  1. Can we use defaults in the nutrition fields to the user's region defaults? So for US users, the default would be 'per serving'

Yes I think it would be a very good idea.

  1. Can we translate the values from 'per 100g' values to 'per serving' values if the radio button is switched? Currently, it does not translate.

Yes it's not translated because in many cases the values per_100g are in fact per_serving and should not be translated. Sometimes people are entering values per 100g but forgot to check 'per serving': if they check after they have filed the values they won't be happy if the values are translated...

It would be interesting to see if the majority of issues needs to translate the values.

@teolemon teolemon transferred this issue from openfoodfacts/openfoodfacts-web Nov 15, 2023
@teolemon teolemon moved this to To discuss and validate in 🍊 Open Food Facts Server issues Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To discuss and validate
Status: To Discuss & Validate
Status: To do
Development

No branches or pull requests

3 participants