Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When no avail translations, We should display English text rather than no text at all or taxonomy formatted text #6771

Closed
teolemon opened this issue May 13, 2022 · 1 comment
Closed

When no avail translations, We should display English text rather than no text at all or taxonomy formatted text #6771

teolemon opened this issue May 13, 2022 · 1 comment
Assignees
@alexgarel
Labels
🐛 bug This is a bug, not a feature request. 📖 Knowledge Panels - https://wiki.openfoodfacts.org/Knowledge_panels
Milestone
Smoothie Launch (...

Comments

@teolemon
Copy link
Member

teolemon commented May 13, 2022 •
edited
Loading

What

  • When no available translations in a language, we should display English text rather than no text at all (in the case of the Bulgarian knowledge subpanel for AB Bio) or taxonomy formatted text (in the case of the Bulgarian knowledge panel title for AB Bio)
  • Plus, we should add a link to the right Crowdin template for this language (or at least a link to the Server crowdin template) or to the taxonomy translation page on the website

Part of

Screenshot

image
@teolemon teolemon added 🌐 i18n Regarding software localization 🧬 Taxonomies - Translation Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org 📖 Knowledge Panels - https://wiki.openfoodfacts.org/Knowledge_panels 🎯 P1 labels May 13, 2022
@stephanegigandet stephanegigandet moved this from Todo to Sprint (prioritized, max 10) in 🍊 Open Food Facts Server issues May 16, 2022
@stephanegigandet stephanegigandet self-assigned this May 16, 2022
@teolemon teolemon removed 🌐 i18n Regarding software localization 🎯 P1 🧬 Taxonomies - Translation Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org 📖 Knowledge Panels - https://wiki.openfoodfacts.org/Knowledge_panels labels May 16, 2022
@alexgarel alexgarel moved this from Sprint (in priority order, max 10) to In Progress in 🍊 Open Food Facts Server issues May 18, 2022
alexgarel added a commit that referenced this issue May 20, 2022
@alexgarel
fix: fallback to english for knowledge panels
3468601 
fixes #6771
@alexgarel alexgarel mentioned this issue May 20, 2022
Merged
@teolemon teolemon added 🐛 bug This is a bug, not a feature request. 📖 Knowledge Panels - https://wiki.openfoodfacts.org/Knowledge_panels labels May 22, 2022
@teolemon teolemon moved this from To discuss and validate to Todo (ready 2 dev) in 🤳🥫 The Open Food Facts mobile app (Android & iOS) May 22, 2022
alexgarel added a commit that referenced this issue May 30, 2022
@alexgarel
fix: fallback to english for knowledge panels (#6804)
43712b5 
* fix: fallback to english for knowledge panels

fixes #6771
@alexgarel alexgarel moved this from In Progress to Done in 🍊 Open Food Facts Server issues May 30, 2022
@alexgarel
Copy link
Member

This is done.

Repository owner moved this from Todo (ready 2 dev) to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexgarel alexgarel

Labels
🐛 bug This is a bug, not a feature request. 📖 Knowledge Panels - https://wiki.openfoodfacts.org/Knowledge_panels
Projects
🍊 Open Food Facts Server issues
Archived in project
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
Smoothie Launch (server readiness)
Development

No branches or pull requests
3 participants
@alexgarel @teolemon @stephanegigandet