Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit product page freezes for complex products #6222

Open
Tracked by #8764
aquilax opened this issue Dec 25, 2021 · 3 comments
Open
Tracked by #8764

Edit product page freezes for complex products #6222

aquilax opened this issue Dec 25, 2021 · 3 comments
Labels
good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. JavaScript 🚅 Performance ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.

Comments

@aquilax
Copy link
Contributor

aquilax commented Dec 25, 2021 •
edited by teolemon
Loading

What

  • Opening the edit page for products with multiple languages and images freezes the page for several minutes before it becomes responsive again

To Reproduce

  1. Log in to https://world.openfoodfacts.org/
  2. Open https://world.openfoodfacts.org/cgi/product.pl?type=edit&code=3274080005003
  3. Try to click on any field

Expected behavior

Page to be responsive withing 30 seconds

Screenshots

Screenshot_2021-12-25_16-11-38
Screenshot_2021-12-25_16-12-56

Additional context

JS Heap grew up to 145 169 532.

Browser version

Chrome Version 96.0.4664.110 (Official Build) (64-bit)

Part of
@aquilax aquilax added the 🐛 bug This is a bug, not a feature request. label Dec 25, 2021
@stephanegigandet
Copy link
Contributor

I'm not sure what would be the best way to solve that. Maybe some lazy loading of images, showing only the last 10 images uploaded or something, with a way to load more. It certainly isn't useful to load tons of images when someone just wants to update one field somewhere. My javascript isn't good enough to fix this though.

@alexgarel
Copy link
Member

alexgarel commented Jan 21, 2022 •
edited
Loading

I think we may find a small JS lib that does this.

Something like https://www.jqueryscript.net/loading/Asynchronous-Image-Loading-jQuery-hbaLoadImages.html

or https://www.jqueryscript.net/loading/image-lazy-rate.html

@github-actions
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Apr 22, 2022
@alexgarel alexgarel added the good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. label Apr 22, 2022
@teolemon teolemon mentioned this issue Jul 31, 2023
Open
@teolemon teolemon moved this to To discuss and validate in 🍊 Open Food Facts Server issues Apr 23, 2024
@teolemon teolemon removed the 🐛 bug This is a bug, not a feature request. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. JavaScript 🚅 Performance ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.
Projects
Good first issues across Open Food Facts
Status: To triage
JavaScript issues across Open Food Facts
Status: No status
🍊 Open Food Facts Server issues
Status: To discuss and validate
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alexgarel @aquilax @teolemon @stephanegigandet