Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs in the build process #3124

Open
Tracked by #5512
teolemon opened this issue Mar 27, 2020 · 4 comments · Fixed by #3322
Open
Tracked by #5512

Bugs in the build process #3124

teolemon opened this issue Mar 27, 2020 · 4 comments · Fixed by #3322
Labels
CI Continuous integration 👩‍💻 DevOps 🐋 Docker https://docker-curriculum.com/ ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.

Comments

@teolemon
Copy link
Member

teolemon commented Mar 27, 2020

Many warnings like this in the build process. Is it normal ? Is it something we can optimize ?

A timestamped file does not exist. Falling back to process start time, in case we are running in different Docker containers. {fallback => 1585249839,path => "/home/runner/work/openfoodfacts-server/openfoodfacts-server/html/css/dist/app.css",source => "CSS file generated by the 'npm run build' command"}
A timestamped file does not exist. Falling back to process start time, in case we are running in different Docker containers. {fallback => 1585249839,path => "/home/runner/work/openfoodfacts-server/openfoodfacts-server/html/css/dist/product-multilingual.css",source => "CSS file generated by the 'npm run build' command"}
A timestamped file does not exist. Falling back to process start time, in case we are running in different Docker containers. {fallback => 1585249839,path => "/home/runner/work/openfoodfacts-server/openfoodfacts-server/html/js/dist/product-multilingual.js",source => "JS file generated by the 'npm run build' command"}
A timestamped file does not exist. Falling back to process start time, in case we are running in different Docker containers. {fallback => 1585249841,path => "/home/runner/work/openfoodfacts-server/openfoodfacts-server/html/css/dist/app.css",source => "CSS file generated by the 'npm run build' command"}

A timestamped file does not exist. Falling back to process start time, in case we are running in different Docker containers. {fallback => 1585249841,path => "/home/runner/work/openfoodfacts-server/openfoodfacts-server/html/css/dist/product-multilingual.css",source => "CSS file generated by the 'npm run build' command"}
A timestamped file does not exist. Falling back to process start time, in case we are running in different Docker containers. {fallback => 1585249841,path => "/home/runner/work/openfoodfacts-server/openfoodfacts-server/html/js/dist/product-multilingual.js",source => "JS file generated by the 'npm run build' command"}

A timestamped file does not exist. Falling back to process start time, in case we are running in different Docker containers. {fallback => 1585249847,path => "/home/runner/work/openfoodfacts-server/openfoodfacts-server/html/css/dist/app.css",source => "CSS file generated by the 'npm run build' command"}
A timestamped file does not exist. Falling back to process start time, in case we are running in different Docker containers. {fallback => 1585249847,path => "/home/runner/work/openfoodfacts-server/openfoodfacts-server/html/css/dist/product-multilingual.css",source => "CSS file generated by the 'npm run build' command"}
A timestamped file does not exist. Falling back to process start time, in case we are running in different Docker containers. {fallback => 1585249847,path => "/home/runner/work/openfoodfacts-server/openfoodfacts-server/html/js/dist/product-multilingual.js",source => "JS file generated by the 'npm run build' command"}

Part of

@teolemon teolemon added 🐛 bug This is a bug, not a feature request. CI Continuous integration labels Mar 27, 2020
@hangy
Copy link
Member

hangy commented Mar 29, 2020

Yes, we should do something about that. The problem is that this code without a code block is apparently always called when ProductOpener::Display is imported. Therefore it's probably better to move it into a sub which gets called in startup_apache2.pl.

Since we now have more files that are generated/minified by gulp, and then put into the dist directories, there could also be an advantage in simply iterating through all files in there recursively, than listing them in Display.pm. If the directory does not exist (Docker scenario with nginx front end proxy in a different container), use the current time for all files.

There's an additional opportunity for optimization in here. We have over 60 references to /css/dist/ and /js/dist/ files in here, which are don't use the timestamp right now, since we didn't list them in %file_timestamps manually.

@stephanegigandet
Copy link
Contributor

Re-opening as the symptom was fixed, but not the resolution suggested by @hangy

@github-actions
Copy link
Contributor

Stale issue message

Copy link
Contributor

github-actions bot commented Mar 4, 2024

This issue has been open 90 days with no activity. Can you give it a little love by linking it to a parent issue, adding relevant labels and projets, creating a mockup if applicable, adding code pointers from https://github.com/openfoodfacts/openfoodfacts-server/blob/main/.github/labeler.yml, giving it a priority, editing the original issue to have a more comprehensive description… Thank you very much for your contribution to 🍊 Open Food Facts

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Mar 4, 2024
@teolemon teolemon moved this to To discuss and validate in 🍊 Open Food Facts Server issues Apr 23, 2024
@teolemon teolemon changed the title (A timestamped file does not exist. Falling back to process start time, in case we are running in different Docker containers.) Bugs in the build process Bugs in the build process Aug 6, 2024
@teolemon teolemon added the 🐋 Docker https://docker-curriculum.com/ label Aug 6, 2024
@teolemon teolemon removed the 🐛 bug This is a bug, not a feature request. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration 👩‍💻 DevOps 🐋 Docker https://docker-curriculum.com/ ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.
Projects
Status: To discuss and validate
Development

Successfully merging a pull request may close this issue.

3 participants