Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues to deploy /lang directory as-is in production #2705

Open
stephanegigandet opened this issue Dec 2, 2019 · 4 comments
Open

Fix issues to deploy /lang directory as-is in production #2705

stephanegigandet opened this issue Dec 2, 2019 · 4 comments
Labels
🌐 i18n Regarding software localization static content This lives at https://github.com/openfoodfacts/openfoodfacts-web

Comments

@stephanegigandet
Copy link
Contributor

This is a meta-bug to identify issues that need to be fixed if we want to deploy the /lang directory as-is in production, instead of hand picking files and copying them manually.

  1. Bad translations / Outdated translations

Texts have been translated in 2 ways:

  • Historically, using pages on OFF wikis. Those translations are very good, but they may be old.
  • Through crowdin, from the English text. Some of those translations are quite bad (meaning you see them and you cringe).

Going forward, we probably need to standardize on using Crowdin for texts translation (as it's easier to update parts of the translations), but we first need to review the texts in OFF main languages.

e.g. compare those 2 pages:

  1. Broken links

The URLs of some pages in some languages have been translated. E.g. the /discover page is /decouvrir in French.

Some of those pages with translated names are in github (e.g. for French), but most are not (e.g. for German, in production, there are many files with translated names in /srv/off/lang/de/texts that are not in github). Some are in github but are broken (e.g. https://es.openfoodfacts.org/contribuir is a copy of the /descubrir text).

Proposed solution: remove files with translated names from github (once we have fixed the bad translations from the first item above), and implement #1818 so that we can keep translated URLs.

@stephanegigandet stephanegigandet added 🐛 bug This is a bug, not a feature request. 🌐 i18n Regarding software localization labels Dec 2, 2019
@stephanegigandet
Copy link
Contributor Author

I deployed the master branch, with the /lang directory on the dev server:
https://uk.openfoodfacts.dev
https://es.openfoodfacts.dev
https://de.openfoodfacts.dev
https://it.openfoodfacts.dev

@teolemon
Copy link
Member

teolemon commented Dec 2, 2019

I started porting your (better) translations to Crowdin.

@hangy hangy added ✨ Feature Features or enhancements to Open Food Facts server and removed 🐛 bug This is a bug, not a feature request. labels Dec 12, 2019
@teolemon teolemon added the static content This lives at https://github.com/openfoodfacts/openfoodfacts-web label Jan 10, 2020
@teolemon
Copy link
Member

#2831 is adding variables to the config files so that we can remove language dependant images, urls and often changing numbers from the files.
This reduces risk of bad translations, and reduces retranslations.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2020

Stale issue message

@teolemon teolemon moved this to To discuss and validate in 🍊 Open Food Facts Server issues Apr 23, 2024
@teolemon teolemon removed the ✨ Feature Features or enhancements to Open Food Facts server label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 i18n Regarding software localization static content This lives at https://github.com/openfoodfacts/openfoodfacts-web
Projects
Status: To discuss and validate
Development

No branches or pull requests

3 participants