Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not take into account values less than #11075

Closed
aleene opened this issue Dec 1, 2024 · 3 comments · Fixed by #11076
Closed

Do not take into account values less than #11075

aleene opened this issue Dec 1, 2024 · 3 comments · Fixed by #11076
Assignees
@benbenben2
Labels
🧽 Data quality - False positives 🧽 Data quality - Nutrition 🧽 Data quality https://wiki.openfoodfacts.org/Quality

Comments

@aleene
Copy link
Contributor

aleene commented Dec 1, 2024

What

Error is: Nutrition-soluble-fiber-plus-insoluble-fiber-greater-than-fiber

Steps to reproduce the behaviour

see: https://world.openfoodfacts.org/product/0856651002104/chili-lime-chickpeas-the-good-bean

Expected behaviour

no error. the algorithm should ignore values with a < sign
@github-project-automation github-project-automation bot moved this to To discuss and validate in 🍊 Open Food Facts Server issues Dec 1, 2024
@benbenben2 benbenben2 mentioned this issue Dec 1, 2024
Merged
@CharlesNepote CharlesNepote added the 🧽 Data quality https://wiki.openfoodfacts.org/Quality label Dec 2, 2024
@CharlesNepote
Copy link
Member

Should it ignore values or should it take into account value with "<" minus 1?

@aleene
Copy link
Contributor Author

aleene commented Dec 2, 2024

I think we should ignore the values

@jusdekiwi
Copy link

I agree with Aleene!

@benbenben2 benbenben2 self-assigned this Dec 2, 2024
@github-project-automation github-project-automation bot moved this from To discuss and validate to Done in 🍊 Open Food Facts Server issues Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benbenben2 benbenben2

Labels
🧽 Data quality - False positives 🧽 Data quality - Nutrition 🧽 Data quality https://wiki.openfoodfacts.org/Quality
Projects
🍊 Open Food Facts Server issues
Archived in project
🧽 Ensuring Data Quality
Archived in project
Milestone
No milestone
5 participants
@CharlesNepote @aleene @teolemon @jusdekiwi @benbenben2