Product changes on the pro platform incorrectly written to the public platform MongoDB database

[stephanegigandet]

Bug reported by @manon-corneille on Slack: https://openfoodfacts.slack.com/archives/C01E2SPNQJW/p1732725011612459

There is a bug that was introduced in the recent code change for better support of product types that resulted in the pro platform writing products to the public platform MongoDB database.

We use MongoDB as a query cache and not at the source of truth, so there's no data loss, but we will need to clean MongoDB to reindex products from the pro platform.

[stephanegigandet]

Investigation

• org-omie homepage https://world.pro.openfoodfacts.org/org/org-omie shows 28 products, not including https://world.pro.openfoodfacts.org/product/3760325484028/muesli-chocolat-noisettes-omie which is accessible by direct access
• checking MongoDB to see if the product is somewhere:
  off-pro> db.products.find({code: "3760325484028"}, {code:1, owner:1})
  no results

looking at import logs

[777610497] /srv/off-pro/lib/ProductOpener/Import.pm 2247 ProductOpener.Import {Owner_id => 'org-omie',code => '3760325484028',org_id => 'omie',product_id => 'org-omie/3760325484028'} storing product
[..]
[777610506] /srv/off-pro/lib/ProductOpener/Products.pm 2642 ProductOpener.Products {code => '3760325484028',product_id => 'org-omie/3760325484028'} compute_product_history_and_completeness - done

-> looks ok
test: editing the product manually on the pro platform works, but the product still isn’t in search results
testing on a dev environment for the pro platform
source env/setenv.sh off-pro
make run_deps
docker-compose start
modifying the title of a product: the title is modified in the .sto file, but not in the mongodb database

Debugging

The problem can be reproduced in local dev environment.

Adding more logs in store_product() in Products.pm:

   $log->debug("store_product - saving product in MongoDB", {new_products_collection => $new_products_collection, code => $code, product_id => $product_id})
       if $log->is_debug();
   $new_products_collection->replace_one({"_id" => $product_ref->{_id}}, $product_ref, {upsert => 1});

the output is a bit messy, but the issue seems to be that the database is off instead of off-pro…

$VAR1->{new_products_collection}{bson_codec},max_time_ms => 50000,name => 'off',read_concern => $VAR1->{new_products_collection}{database}{_client}{_read_concern},read_preference => $VAR1->{new_products_collection}{database}{_client}{_read_preference},write_concern => $VAR1->{new_products_collection}{database}{_client}{_write_concern}}, 'MongoDB::Database' )

Indeed I made a mistake when changing the code for the merge of the flavours, and off-pro is writing to MongoDB database of the public platform.. :(