Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serving size: "missing digits" error is too strict: allow entering dash to express missing data #10961

Closed
aleene opened this issue Nov 1, 2024 · 5 comments · Fixed by #11161
Assignees
Labels
🧽 Data quality https://wiki.openfoodfacts.org/Quality serving size ⭐ top issue Top issue.

Comments

@aleene
Copy link
Contributor

aleene commented Nov 1, 2024

What

When I want to specify that a product does not mention a portion/serving size, I would like to enter a dash (-). Thius now results in an error.

Steps to reproduce the behaviour

Just enter a dash ("-") in the field and save

Expected behavior

No error

Why

Entering missing data is also data

Type of device

  • Browser: Safari

Number of products impacted

Many

@jusdekiwi
Copy link

That would be a cool feature! Same as for the fibers in the NT.

@CharlesNepote
Copy link
Member

In the serving size isn't it? Seems to be quite rare for me. Can you give few examples to be sure?

In the meantime, you can use Folksonomy Engine to do so, but I guess it would be better to allow dash in the Serving size field.

@October-Food-Facts
Copy link

Can we get this standard for quantities too? Many products don't specify an amount, a weight – not being required by law in a number of cases.

@jusdekiwi
Copy link

In the serving size isn't it? Seems to be quite rare for me. Can you give few examples to be sure?

In the meantime, you can use Folksonomy Engine to do so, but I guess it would be better to allow dash in the Serving size field.

You mean you don't often see products without a serving size? seems to happen >50% of the time for me

@CharlesNepote CharlesNepote added the 🧽 Data quality https://wiki.openfoodfacts.org/Quality label Nov 12, 2024
@benbenben2 benbenben2 self-assigned this Dec 21, 2024
@benbenben2 benbenben2 moved this from To do to Needs review in 🧽 Ensuring Data Quality Dec 21, 2024
benbenben2 added a commit that referenced this issue Dec 22, 2024
### What
allow serving size to be hyphen ("-")


### Related issue(s) and discussion
- Fixes #10961
@github-project-automation github-project-automation bot moved this from Needs review to Done in 🧽 Ensuring Data Quality Dec 22, 2024
@github-project-automation github-project-automation bot moved this from To discuss and validate to Done in 🍊 Open Food Facts Server issues Dec 22, 2024
@CharlesNepote CharlesNepote changed the title Big: Serving size is missing digits to strict Serving size is missing digits too strict Jan 7, 2025
@CharlesNepote CharlesNepote changed the title Serving size is missing digits too strict Serving size: "missing digits" error is too strict: allow entering dash to express missing data Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧽 Data quality https://wiki.openfoodfacts.org/Quality serving size ⭐ top issue Top issue.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants