Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synonyms in taxonomized suggestions are broken #10632

Closed
October-Food-Facts opened this issue Aug 3, 2024 · 2 comments · Fixed by #10722
Closed

Synonyms in taxonomized suggestions are broken #10632

October-Food-Facts opened this issue Aug 3, 2024 · 2 comments · Fixed by #10722
Assignees
@Naruyoko
Labels
🐛 bug This is a bug, not a feature request. ✏️ Editing - Auto Suggest Providing autosuggest for taxonomized fields. Mostly used in editing scenarii 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies

Comments

@October-Food-Facts
Copy link

What

How it used to be:
Past

How it is now:
Present
@github-project-automation github-project-automation bot moved this to To discuss and validate in 🍊 Open Food Facts Server issues Aug 3, 2024
@teolemon teolemon added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies ✏️ Editing - Auto Suggest Providing autosuggest for taxonomized fields. Mostly used in editing scenarii 🐛 bug This is a bug, not a feature request. labels Aug 6, 2024
@Naruyoko
Copy link
Contributor

Naruyoko commented Aug 9, 2024

This line is the culprit.

openfoodfacts-server/html/js/product-multilingual.js

Line 592 in c6a0564

let whitelist = json.suggestions;

Compare:

openfoodfacts-server/html/js/product-multilingual.js

Line 582 in 908603a

let whitelist = Object.values(json.matched_synonyms);

@October-Food-Facts
Copy link
Author

If this can be fixed, it would be great, because the taxonomies are really, really difficult to fill-in and end up taking hours of work to figure out. Without the synonyms, it's only so much harder.

@Naruyoko Naruyoko self-assigned this Aug 21, 2024
Naruyoko added a commit to Naruyoko/openfoodfacts-server that referenced this issue Aug 21, 2024
@Naruyoko
Fix openfoodfacts#10632: Synonyms in taxonomized suggestions are broken
28c9dd9 
openfoodfacts#10632 (comment)
@Naruyoko Naruyoko mentioned this issue Aug 21, 2024
Merged
@github-project-automation github-project-automation bot moved this from To discuss and validate to Done in 🍊 Open Food Facts Server issues Aug 22, 2024
@October-Food-Facts October-Food-Facts mentioned this issue Aug 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Naruyoko Naruyoko

Labels
🐛 bug This is a bug, not a feature request. ✏️ Editing - Auto Suggest Providing autosuggest for taxonomized fields. Mostly used in editing scenarii 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
🍊 Open Food Facts Server issues
Archived in project
Milestone
No milestone
3 participants
@teolemon @Naruyoko @October-Food-Facts