From 08861fbe2978d6577a4ba64b522a5a1c6ee90a09 Mon Sep 17 00:00:00 2001
From: Alex Garel <alex@openfoodfacts.org>
Date: Tue, 26 Mar 2024 12:07:33 +0100
Subject: [PATCH] =?UTF-8?q?fix:=C2=A0re-activate=20critic=20rule=20(#10031?=
 =?UTF-8?q?)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .perlcriticrc | 2 +-
 Makefile      | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/.perlcriticrc b/.perlcriticrc
index 6227d4a529068..57d7274c523cb 100644
--- a/.perlcriticrc
+++ b/.perlcriticrc
@@ -17,7 +17,7 @@ only 		= 1
 [Modules::ProhibitEvilModules]
 [Modules::RequireBarewordIncludes]
 
-[-Modules::RequireFilenameMatchesPackage]
+[Modules::RequireFilenameMatchesPackage]
 
 [Subroutines::ProhibitExplicitReturnUndef]
 [Subroutines::ProhibitNestedSubs]
diff --git a/Makefile b/Makefile
index 902db1bfede11..ff628c9360e68 100644
--- a/Makefile
+++ b/Makefile
@@ -359,6 +359,8 @@ lint_perltidy:
 
 #Checking with Perl::Critic
 # adding an echo of search.pl in case no files are edited
+# note: to run a complete critic on all files (when you change policy), use:
+# find . -regex ".*\.\(p[lM]\|t\)"|grep -v "/\."|grep -v "/obsolete/"|xargs docker compose run --rm --no-deps -T backend perlcritic
 check_critic:
 	@echo "🥫 Checking with perlcritic"
 	test -z "${TO_CHECK}" || ${DOCKER_COMPOSE} run --rm --no-deps backend perlcritic ${TO_CHECK}