Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consumption-related fields - quantity bought doesn't seem to be computed #1169

Open
serpico opened this issue Dec 25, 2024 · 7 comments
Open

Comments

@serpico
Copy link

serpico commented Dec 25, 2024

What

I noticed ( thanks to the refreshed amount and associated infos recently implemented 👍 ) a discrepancy between the sum calculated by OP and the actual amount we input at the beginning, since I have only 1 product I bought twice it was easy to spot where the source was ( see screenshot )

Screenshots

Image

@raphodn
Copy link
Member

raphodn commented Dec 25, 2024

Merry Christmas :)

Are you talking about the number on the left (count), or on the right (sum) ?

  • left : I also realized that it's summing unique products (without the quantity)
  • right : it should take the quantity into account

@raphodn
Copy link
Member

raphodn commented Dec 25, 2024

In this example, when you inputed 10 as the "number of prices" on the receipt, did you count the baguette once or twice ?

Would you rather count it once ? And rename the field to "number of unique prices" ?

Receipts sometimes display the unique count, and sometimes take the duplicates into account.. So for future auto-extraction it's going to be tricky ^^

@serpico
Copy link
Author

serpico commented Dec 25, 2024

Baguette, for me, 1 price and quantity bought 2, match the receipt as well as the amount I'll eat.
In that case I find the UI/input fields straightforward, logical as it is.

left : it says 10/10 prices so I'm fine with it, there, really, are 10 prices here in my receipt.
right : yeah, that's how I felt as well.

As you may have realized based on the issues I open or get involved in, I don't care/don't understand that much about auto-extraction and all the AI bells and whistles :) ( although I should probably be more open to it or will change my mind when I won't be able to escape all the marvelous things it's gonna do with/for OP in the future ).

I do care about accuracy and your plan about the personal "tracking" feature ( "let's see how many/the mass of turkey legs I bought during the last 5 years, what does the trend look like, hmmm now what about those duck drumsticks"...) which, IIRC, triggered the fact that we have now the "quantity bought" value.

Merry Christmas to you too.

@raphodn
Copy link
Member

raphodn commented Dec 25, 2024

So in your initial screenshot you would expect it to display "0,7 € (x2)" instead of "0,35 € (x2)" ?

We could rename to "0,35 € (bought 2)" to be slightly more explicit..

But it's still ambiguous..

Or add a new line with the total amount !

@serpico
Copy link
Author

serpico commented Dec 25, 2024

To be honest what I saw was the total price that didn't match the one I reported/typed in at the initial step ( when we choose location, date, currency...) , I was expecting to see 14,36€ / 14,36€ instead of 14,01€ / 14,36€ as in the screenshot.

The rest feel fine to me, the unit price ( 0,35€ ) is correctly reported, so is the number of product ( x2 encircled ) bought.

If I see 10/10 and 14,36€ / 14,36€ it means everything was entered as per the receipt and is correct, that's the kind of information I'm expecting here.

@raphodn
Copy link
Member

raphodn commented Dec 30, 2024

Justin also mentioned that for bulk products it should be possible to specify decimal quantities (for instance buying 1.5 kg of bananas)

edit: linked to #1090

@raphodn
Copy link
Member

raphodn commented Jan 2, 2025

Todo

  • fix amount discrepancy
  • allow adding decimal in receipt_quantity
  • clarify if amount per kg or per unit
  • if receipt_quantity inputed, add an extra line indicating the total amount
  • display this info elswehere. for instance in the proof detail view ?

@raphodn raphodn changed the title Quantity bought doesn't seem to be computed consumption-related fields - quantity bought doesn't seem to be computed Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

2 participants