-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search functionality should have more visibility into datasets #57
Comments
IIRC it's based on the title and the description. I don't disagree this might be useful generally - but in this specific case having some text describing the |
Thank you Bryan. Just tested by adding 'subcontractors' to the description of the dataset and that did indeed make it appear in the search. From here on out, we'll aim to list out the dataset names that may fall under one overarching dataset in the description.
If you're able to implement broader search functionality in the future that would be great as I don't know when/if we'll be able to go back and do this for all of our previously released datasets.
Best,
Kistine
[cid:27ebbc6c-d69b-4f4d-9e7f-77901ed64618]
Kistine Carolan
Senior Program Manager, PHL Open Data Program<https://www.phila.gov/programs/open-data-program/>
Office of Innovation & Technology, City of Philadelphia
o: 1234 Market Street | Philadelphia, PA 19107
e: ***@***.***
…________________________________
From: BryanQuigley ***@***.***>
Sent: Thursday, May 11, 2023 3:10 PM
To: azavea/opendataphilly-jkan ***@***.***>
Cc: Kistine Carolan ***@***.***>; Mention ***@***.***>
Subject: Re: [azavea/opendataphilly-jkan] Extend Search to include Dataset Descriptions and the Title of the Resource records (Issue #57)
External Email Notice. This email comes from outside of City government. Do not click on links or open attachments unless you recognize the sender.
________________________________
IIRC it's based on the title and the description.
I don't disagree this might be useful generally - but in this specific case having some text describing the
Subcontractors resources in that description would be helpful as well (and should make it searchable).
—
Reply to this email directly, view it on GitHub<#57 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADTMWPF4XED7XZZIYLPBFOLXFU2QRANCNFSM6AAAAAAX6NVLRU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Is it possible to also check my privileges? Currently, I don't seem to be able to create branches for submitting pull requests.
Best,
Kistine
[cid:1860aa79-fe96-4030-a73c-0a11f79d51cf]
Kistine Carolan
Senior Program Manager, PHL Open Data Program<https://www.phila.gov/programs/open-data-program/>
Office of Innovation & Technology, City of Philadelphia
o: 1234 Market Street | Philadelphia, PA 19107
e: ***@***.***
…________________________________
From: Kistine Carolan ***@***.***>
Sent: Thursday, May 11, 2023 4:15 PM
To: azavea/opendataphilly-jkan ***@***.***>; azavea/opendataphilly-jkan ***@***.***>
Cc: Mention ***@***.***>
Subject: Re: [azavea/opendataphilly-jkan] Extend Search to include Dataset Descriptions and the Title of the Resource records (Issue #57)
Thank you Bryan. Just tested by adding 'subcontractors' to the description of the dataset and that did indeed make it appear in the search. From here on out, we'll aim to list out the dataset names that may fall under one overarching dataset in the description.
If you're able to implement broader search functionality in the future that would be great as I don't know when/if we'll be able to go back and do this for all of our previously released datasets.
Best,
Kistine
[cid:27ebbc6c-d69b-4f4d-9e7f-77901ed64618]
Kistine Carolan
Senior Program Manager, PHL Open Data Program<https://www.phila.gov/programs/open-data-program/>
Office of Innovation & Technology, City of Philadelphia
o: 1234 Market Street | Philadelphia, PA 19107
e: ***@***.***
________________________________
From: BryanQuigley ***@***.***>
Sent: Thursday, May 11, 2023 3:10 PM
To: azavea/opendataphilly-jkan ***@***.***>
Cc: Kistine Carolan ***@***.***>; Mention ***@***.***>
Subject: Re: [azavea/opendataphilly-jkan] Extend Search to include Dataset Descriptions and the Title of the Resource records (Issue #57)
External Email Notice. This email comes from outside of City government. Do not click on links or open attachments unless you recognize the sender.
________________________________
IIRC it's based on the title and the description.
I don't disagree this might be useful generally - but in this specific case having some text describing the
Subcontractors resources in that description would be helpful as well (and should make it searchable).
—
Reply to this email directly, view it on GitHub<#57 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADTMWPF4XED7XZZIYLPBFOLXFU2QRANCNFSM6AAAAAAX6NVLRU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Improving the search is definitely on the TODO, but I have no idea when we can get to it. The goal is actually to completely switch to a new powerful system. It really doesn't matter if they are created in your fork or in this repo, - in fact, for anyone else we definitely want them doing the fork/PR/review setup - not needing write access here. That has me thinking for the case of editing a single dataset by you or @rcheetham @lydiascarf if we should not require a 2nd reviewer (or otherwise lower our requirements to just CI passing). Thoughts? (I can mock something up) |
Regarding permissions:
Regarding search:
|
permissions. As for search here is the JKAN issue: timwis/jkan#225 There aren't specific requirements but I've also been looking at projects like https://stork-search.net/ in addition to lunr.js. I think the first thing is to come up with a list of possible goals:
Ideally with a similar flow to the current site - I really like how fast it is and how it doesn't break the view. But many of these other search engines might not work like that - they might be separate pages or pop-outs. Is that worth the trade-off? |
Hi Lydia,
Sorry it slipped by me to accept the invitation - can you resend it? My
gmail address is fine
Thanks!
…On Tue, May 16, 2023 at 8:09 AM Lydia Scarf ***@***.***> wrote:
Regarding permissions:
- @Kistine <https://github.com/Kistine> I've invited you to
collaborate via your work email, which should fix your permissions issue,
but please let me know if it doesn't!
- Also, @Alexander-M-Waldman <https://github.com/Alexander-M-Waldman>
and @jrmidkiff <https://github.com/jrmidkiff>, your invites expired
without being accepted. Would you like me to send them to different email
addresses?
- @BryanQuigley <https://github.com/BryanQuigley> I can also handle
setting up laxer reviewer requirements for trusted people. I'm already
working on a CODEOWNERS file so that someone from the city gets requested
if a PR touches a city dataset. I think what you're describing can be
covered by that file as well but I'll dig in more today.
Regarding search:
- @BryanQuigley <https://github.com/BryanQuigley> I've got some
availability to look into overhauling search. Was there a particular
solution/plugin you were looking into? Let's focus this ticket on that
search overhaul going forward (changing the title now)
—
Reply to this email directly, view it on GitHub
<#57 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGIJKQDIZRZTW7KZERUKXA3XGOKELANCNFSM6AAAAAAX6NVLRU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Best,
James Midkiff
|
@BryanQuigley this has basically been stalled because off-the-shelf, static solutions are by and large not well maintained. what if i set up an SQLite db of searchable metadata and re-implemented search on top of FTS5? |
Where would it run? Part of me wonders if we should just leave the existing search as is, but add an external search provider as an option to the main page.. Google seems like it has the best results from my quick test, but I'm curious about DuckDuckGo/Stract/others too. |
my thought was it would run in-memory on the client side using sql.js. SQLite is very lightweight and it could be useful for other issues like a dynamic hero image slideshow, expansions to filtering, etc. all it would need is an action to keep it synced and then it would be available for all kinds of dynamic reads. something like this feels more in keeping with the JKAN principles of relying on FOSS over platforms and building things to be customizable, but i might not be seeing the whole picture |
This is report from @Kistine about trouble finding data sets:
The text was updated successfully, but these errors were encountered: