-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First feedback: Installation problems #22
Comments
Hi, This looks pretty impressiv already! I looked into it and this is my feedback so far:
@jnnr is there some specific aspect we should have a look at or test? |
Thanks for the feedback! Until now, the functionality is centered around reading data in the specified format, checking for required parameters, setting default parameters and finally getting a consistent ThermalNetwork object with components, component_attrs and sequences. There are some tests, but I am sure there are cases that are not tested yet. You could play around a bit yourself and try to break something? :) Issues and failing tests are welcome. Also, you can have a look at the data format and the specifications of the components, which are contained in the dhnx/components.csv and dhnx/component_attrs (they are also shown in the docs). Maybe you find some attributes that are missing? Beyond that, there will be actual models coming soon, and examples (optimization and simulation). |
How long does it take? More than a minute? Is that because of cartopy? |
yes, I would say more than a minute. *This worked for me: @jnnr what version of Python and cartopy are you using |
With pleasure! ;) |
The requirements are written in the setup.py. Did you install it with
Good to know. What did the error messages say? I consider geopandas quite helpful and would count it to the requirements.
That's why cartopy is part of extras_require. Still we can find a way to replace it or to make installation easier.
Atm python 3.66 and cartopy 0.17.0. |
It was more or less the same for me. It appears like the required packages could not be properly installed from -e flag even though only Rtree gave me an error message. I had to install Rtree manually in the interpreter. Afterwards it was possible to install DHNx. But so far I can say it seems osmnx, cartopy and geopandas were not installed properly, because I get errors or warnings running the examples. |
yes, I did. |
I hope that helps! |
I did the installation on dev branch but still had the above-mentioned problems. |
Right, the problem seems to be something else. The Problem is caused by Fiona. Also when I reproduce my former installation process (one by one) geopandas fails because of Fiona:
The geopandas docu mentions that potential problem, I just noticed:
When I remove geopandas from the requirements-list the package-installation fails later with another package: Rtree. With the same error message as @MaGering wrote above. @MaGering are you using Windows? I do and that might cause the problem with Fiona and Rtree as the geopandas docu also says:
This explains why |
No, I'm using OSX.
Interesting. For me it was not Fiona but tcahumev. |
@MaGering are you using Anconda/Conda? Would be interesting to know if |
Yes I am.
The installation works, but there unfortunately are still errors. import_osmnx.py for example gives me an error related to geopandas.
Sorry, I mixed that up with Rtree. tcahumev was there the problem. |
btw: The installation problems of Cartopy are already discussed in one of their github issues. |
Can you tell me what tcahumev is? I searched it, but got no results at all. |
It appeared multiple times in the traceback. Here, for instance: File "/private/var/folders/0x/6f9bvwdj0jv44yy2tpndnvj80000gn/T/pip-install-tcahumev/Rtree/setup.py", line 3, in I just read that the "private/var" folder is a folder with temporary files on mac OS. So it seems to be a problem connected to installation on mac OS. |
To sum up the installation problems. I checked the box if we found a solutions, which I describe shortly below the bullet point. Can you please update this list @jakob-wo, @MaGering?
|
All mentioned packages are extras_require now, or dependencies of extras_requires. Of course, this is a short term solution, but nothing, which should delay the first release. |
In this issue on oemof/organisation and on the last dev meeting in Berlin we discussed and decided that we want to start developing a repo for district heating models as a joint effort within the oemof-community.
This repo should therefore move to oemof to provide a structure to start with. It provides a central class ThermalNetwork that allows to import data in a defined format. Available components and their required and default attributes are defined (in components.csv and component_attrs). The network data is stored as pandas DataFrames. The ThermalNetwork allows to do a self-consistency check. The whole setup draws some ideas from pypsa.
To get you onboard, have a look at the repo (and open issues if you find things that are worth discussing). To get started, do the following:
@jakob-wo @joroeder @MaGering
The text was updated successfully, but these errors were encountered: