api/consensus/block: Fix response when querying a single block #888
+842
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
force-pushed
the
ptrus/fix/block-proposers
branch
2 times, most recently
from
ce3fc5f to
60f7547
Compare
|
Would it make sense to mark the field as mandatory on the API spec JSON? Or are there some other situations when this piece of data is legitimately not present? |
|
Yes for Will update |
ptrus
force-pushed
the
ptrus/fix/block-proposers
branch
from
60f7547 to
0b52714
Compare
|
Yes I meant the proposer. Thanks.
|
ptrus
force-pushed
the
ptrus/fix/block-proposers
branch
from
0b52714 to
90ee830
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #886
API endpoint returning a single block by height was using a separate code path to fetch the blocks which lead to the regression mentioned in the above issue.
This is now fixed so that a single code path is used when fetching either a single or multiple consensus blocks. This also resolves the issue.