Some improvements for metadata being preserved. #147
+76
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
njtierney
commented
Jan 17, 2025
njtierney
commented
- Update to latest version of terra (1.8-10) to ensure metadata is saved for raster drivers like COG.
- Add documentation that details that some versions GDAL and raster drivers might not save metadata and to contact us if there's an issue
- Add test to ensure metadata is maintained for GTiff and COG
- resolves Discrepancies in how units / metadata can be encoded and restored #146
- Update to latest version of terra (1.8-10) to ensure metadata is saved for raster drivers like COG. - Add documentation that details that some versions GDAL and raster drivers might not save metadata and to contact us if there's an issue - Add test to ensure metadata is maintained for GTiff and COG
29 tasks
Aariq
approved these changes
Jan 17, 2025
Comment on lines
+32
to
+36
| #' metadata for your setup, please file an issue at | ||
| #' \url{https://github.com/njtierney/geotargets/issues/} and we will try and | ||
| #' get this working for you. Also note that you can specify this option for | ||
| #' individual targets, e.g., inside [tar_terra_rast()] there is the option | ||
| #' `preserve_metadata`. |
There was a problem hiding this comment.
I would suggest adding something about trying to test things out with just terra outside of a targets pipeline first to be sure the issue is indeed with geotargets. I often forget to do this and would appreciate the reminder!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.