Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong return type on SequelizeStore.sync()? #152

Open
Jupp56 opened this issue Sep 29, 2024 · 0 comments
Open

Wrong return type on SequelizeStore.sync()? #152

Jupp56 opened this issue Sep 29, 2024 · 0 comments

Comments

@Jupp56
Copy link

Jupp56 commented Sep 29, 2024

Hi,
a quick typescript heads-up:
I think the return type of the sync() method on the SequelizeStore class should be a promise.

The sequelize docs show that syncing a model returns a promise here.
In line 71 of connect-session-sequelize.js, this promise is returned to the caller.

I'll open and link a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant