Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Glean Wrapper for HomepageTelemetry #24074

Open
data-sync-user opened this issue Jan 10, 2025 · 3 comments · May be fixed by #24121
Open

Use Glean Wrapper for HomepageTelemetry #24074

data-sync-user opened this issue Jan 10, 2025 · 3 comments · May be fixed by #24121
Assignees
@krishpranav
Labels
Contributor OK This is a good issue for contributors interested in helping the project Good first issue A good issue to be worked on for first time contributors

Comments

@data-sync-user
Copy link
Collaborator

data-sync-user commented Jan 10, 2025 •
edited
Loading

📄 Description

This ticket is to refactor the HomepageTelemetry to inject GleanWrapper so that we can mock the dependency in unit tests instead of depending on Glean itself. See an example done for the PrivateBrowsingTelemetry under Resources.

📚 Resources

Example ticket in using the Glean wrapper to refactor our PrivateBrowsingTelemetry: https://github.com/mozilla-mobile/firefox-ios/pull/24061

PR to improve our Glean Wrapper: https://github.com/mozilla-mobile/firefox-ios/pull/23925

ℹ️ Reference Person

[~accountid:625c9c3cd7f1b80069bcb183]

┆Issue is synchronized with this Jira Task
@cyndichin cyndichin added Contributor OK This is a good issue for contributors interested in helping the project Good first issue A good issue to be worked on for first time contributors labels Jan 10, 2025
@krishpranav
Copy link

Hi, can i work on this?

@lmarceau
Copy link
Contributor

@krishpranav I assigned it to you, thank you! Let us know if there's anything

@krishpranav krishpranav linked a pull request Jan 14, 2025 that will close this issue
Open
6 tasks
@krishpranav
Copy link

Hi @lmarceau 👋

PR: #24121

This PR implements the requested refactor for HomepageTelemetry by introducing a GleanWrapperProtocol and updating the existing implementation to support dependency injection. The changes were designed with modularity and testability in mind, and all associated test cases have been updated or added to ensure proper coverage.

If you have any feedback, suggestions, or further requests, please feel free to share them. I'm more than happy to iterate on this!

Looking forward to your review and approval! 😊
Thank you for the opportunity to contribute to this amazing project! 🙏✨

Warm regards,
Krisna 🛠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krishpranav krishpranav

Labels
Contributor OK This is a good issue for contributors interested in helping the project Good first issue A good issue to be worked on for first time contributors
Projects
None yet
Milestone
No milestone
4 participants
@cyndichin @lmarceau @data-sync-user @krishpranav