Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.5.0 #783

Closed
hoechenberger opened this issue Aug 19, 2023 · 10 comments · Fixed by #821
Closed

Release 1.5.0 #783

hoechenberger opened this issue Aug 19, 2023 · 10 comments · Fixed by #821

Comments

@hoechenberger
Copy link
Member

@larsoner Looking at the list of changes since the last release, I believe a new one is already overdue. LMK if you agree, and I'll cut a new release

@larsoner
Copy link
Member

Sure but let's wait maybe a week to make sure the BIDS naming stuff is okay and we don't have issues with mne-tools/mne-python#11903

@hoechenberger
Copy link
Member Author

I don't see how this PR pertains to the pipeline..? 🤔

@larsoner
Copy link
Member

See top comment of the PR:

Screenshot 2023-08-19 at 5 03 39 PM

@hoechenberger
Copy link
Member Author

I still don't follow, the FIFF changes would only go into the next MNE release, no? So it won't affect the pipeline when working with MNE 1.5.0

@larsoner
Copy link
Member

Safer to fix them now in case we don't release a new version here before MNE 1.6 comes out

@larsoner
Copy link
Member

I checked and it looks like we're okay, feel free

@larsoner
Copy link
Member

@hoechenberger want me to cut 1.5?

@hoechenberger
Copy link
Member Author

We should address #796 first

@hoechenberger
Copy link
Member Author

@larsoner
Please feel free to cut a release, I don't think I'll have time in the foreseeable future … And I really think we should have a release, it's too many changes that have accumulated already since 1.4!

@larsoner
Copy link
Member

larsoner commented Dec 1, 2023

Okay I cut https://github.com/mne-tools/mne-bids-pipeline/releases/tag/v1.5.0, feel free to adjust the notes and title etc. if you want @hoechenberger . I just took the generated changelog and removed the pre-commit bot PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants