Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workbench search does not use correct findMatch foreground colors #237909

Open
simon-id opened this issue Jan 14, 2025 · 2 comments · May be fixed by #237910
Open

Workbench search does not use correct findMatch foreground colors #237909

simon-id opened this issue Jan 14, 2025 · 2 comments · May be fixed by #237910
Assignees
@osortega

Comments

@simon-id
Copy link

simon-id commented Jan 14, 2025 •
edited
Loading

Type: Bug

Does this issue occur when all extensions are disabled?: Yes

Steps to Reproduce:

  1. Add custom findMatch colors to your configuration:
    "workbench.colorCustomizations": {
        "editor.findMatchHighlightForeground": "#000000",
        "editor.findMatchHighlightBackground": "#ffffb4",
        "editor.findMatchForeground": "#000000",
        "editor.findMatchBackground": "#ff4cde"
    },
  1. Search text using the workbench sidebar search (not the search widget):

Actual behavior:

Match text color is a default blue text color.
Image

Expected behavior:

Match text color should be #000000.
Image

Version informations

VS Code version: Code 1.96.2 (fabdb6a, 2024-12-19T10:22:47.216Z)
OS version: Linux x64 6.5.0-45-generic
Modes:

System Info
Item Value
CPUs 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz (8 x 3914)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: disabled_software
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off
webnn: disabled_off
Load (avg) 1, 1, 2
Memory (System) 15.34GB (2.73GB free)
Process Argv
Screen Reader no
VM 0%
DESKTOP_SESSION ubuntu
XDG_CURRENT_DESKTOP Unity
XDG_SESSION_DESKTOP ubuntu
XDG_SESSION_TYPE wayland
Extensions (22)
Extension Author (truncated) Version
gitstash art 5.2.0
brainfuck-syntax att 0.0.1
vscode-jq dan 1.2.0
vscode-eslint dba 3.0.10
githistory don 0.6.20
gitlens eam 16.1.1
code-runner for 0.12.2
copilot Git 1.257.0
copilot-chat Git 0.23.2
vscode-pull-request-github Git 0.102.0
vscode-docker ms- 1.29.3
vscode-language-pack-fr MS- 1.96.2024121109
debugpy ms- 2024.14.0
python ms- 2024.22.2
vscode-pylance ms- 2024.12.1
cmake-tools ms- 1.19.52
cpptools ms- 1.22.11
cpptools-extension-pack ms- 1.3.0
sublime-keybindings ms- 4.1.10
material-icon-theme PKi 5.17.0
vscode-yaml red 1.15.0
cmake twx 0.0.17

(1 theme extensions excluded)
@vs-code-engineering VS Code Engineering
Copy link

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.96.3. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

@simon-id simon-id linked a pull request Jan 14, 2025 that will close this issue
Open
@simon-id
Copy link
Author

simon-id commented Jan 14, 2025 •
edited
Loading

I can confirm this happens on the main branch. I've published a PR to fix this issue: #237910

@roblourens roblourens assigned osortega and unassigned roblourens Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@osortega osortega

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: workbench search use correct findMatch colors (fix #237909) simon-id/vscode
3 participants
@roblourens @osortega @simon-id