-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSError stack includes the message #136
Comments
Note: my initial thought of searching for message and stripping it out of stack may not work. For example, for a stack overflow message returns
We could try reconstructing the stack out of individual call frames to have the same format, but it could get messy and not sure if all information needed is available. |
tudorms
added a commit
to tudorms/v8-jsi
that referenced
this issue
Jun 16, 2022
This was referenced Jun 16, 2022
ghost
pushed a commit
that referenced
this issue
Jun 17, 2022
* Remove CETCompat * The stack shouldn't include the message as well. Addresses #136
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Per V8's documentation, the Error.stack property will include the message as well, but JSI tracks "message" and "stack" as separate properties.
We need to find a way to strip the message out of the "stack" in JSError.
The text was updated successfully, but these errors were encountered: