Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document MSTEST0038: Don't use 'Assert.AreSame' with value types #44157

Merged
merged 7 commits into from
Jan 15, 2025
Merged

Document MSTEST0038: Don't use 'Assert.AreSame' with value types #44157

merged 7 commits into from
Jan 15, 2025
+47 −0

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Jan 6, 2025 •
edited by github-actions bot
Loading

@Youssef1313 Youssef1313 requested review from IEvangelist and a team as code owners January 6, 2025 08:08
@dotnetrepoman dotnetrepoman bot added this to the January 2025 milestone Jan 6, 2025
@dotnet-policy-service dotnet-policy-service bot added dotnet-fundamentals/svc community-contribution Indicates PR is created by someone from the .NET community. labels Jan 6, 2025
gewarren
gewarren reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add to TOC https://github.com/dotnet/docs/blob/main/docs/navigate/devops-testing/toc.yml.

docs/core/testing/mstest-analyzers/mstest0038.md Outdated Show resolved Hide resolved
docs/core/testing/mstest-analyzers/mstest0038.md Outdated Show resolved Hide resolved
docs/core/testing/mstest-analyzers/mstest0038.md Outdated Show resolved Hide resolved
docs/core/testing/mstest-analyzers/mstest0038.md Outdated Show resolved Hide resolved
@Youssef1313 @gewarren
Apply suggestions from code review
3efde8e 
Co-authored-by: Genevieve Warren <[email protected]>
@Youssef1313
Copy link
Member Author

Ping @IEvangelist @gewarren

@IEvangelist IEvangelist merged commit f72a96a into dotnet:main Jan 15, 2025
8 checks passed
@Youssef1313 Youssef1313 deleted the doc-mstest0038 branch January 15, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren left review comments

@IEvangelist IEvangelist IEvangelist approved these changes

Assignees
No one assigned
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Milestone
January 2025
Development

Successfully merging this pull request may close these issues.

Document Assert.AreSame analyzer
3 participants
@Youssef1313 @IEvangelist @gewarren