.Net: Remove DeleteRecordOptions and UpsertRecordOptions from MEVD #10192
Conversation
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
| /// <param name="cancellationToken">The <see cref="CancellationToken"/> to monitor for cancellation requests. The default is <see cref="CancellationToken.None"/>.</param> | ||
| /// <returns>The unique identifier for the record.</returns> | ||
| /// <exception cref="VectorStoreOperationException">Throw when the command fails to execute for any reason other than that the record does not exit.</exception> | ||
| Task DeleteAsync(TKey key, DeleteRecordOptions? options = default, CancellationToken cancellationToken = default); | ||
| Task DeleteAsync(TKey key, CancellationToken cancellationToken = default); |
There was a problem hiding this comment.
Should we consider obsoleting the old overloads and the options we are removing while adding the new ones. We can then delete the old ones after a couple of months?
There was a problem hiding this comment.
We could... We do need to decide what the release policy will be like in the coming months etc. For this specific case, since these types are empty, they weren't actually useful to anyone, and I suspect that for the vast majority of users the code will compile as-is against the new version (it's a binary break, but that really shouldn't be a big deal between previews...).
I do have some more impactful breaking proposals possibly coming (e.g #10193). I personally wouldn't spend too much time on figuring out backwards compat across these prerelease previews and just push forward - but let me know what you think.
Closes #10172
/cc @westey-m