Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macOS test builders to CI #1394

Closed
dagood opened this issue Nov 7, 2024 · 1 comment
Closed

Add macOS test builders to CI #1394

dagood opened this issue Nov 7, 2024 · 1 comment
Labels
new-platform Support a platform new to the microsoft/go infrastructure

Comments

@dagood
Copy link
Member

dagood commented Nov 7, 2024

This PR adds macOS buildandpack to produce Go toolsets, but doesn't include the standard library tests:

In a test run I ran early on, devscript worked, but test didn't. (test may run additional tests, but it isn't quite longtest and should be reliable.)

https://dev.azure.com/dnceng/internal/_build/results?buildId=2575070&view=logs&j=1fc39dc4-3ae2-57e7-a254-ceccd9c00bb3&t=e8fde53a-663f-5432-3a67-c3eefd0bab24&l=200

panic: test timed out after 9m0s
	running tests:
		TestLookupNoSuchHost (8m58s)
		TestLookupNoSuchHost/LookupNS_NXDOMAIN (2m54s)
		TestLookupNoSuchHost/LookupNS_NXDOMAIN/forced_cgo_resolver (22s)

I didn't investigate at the time and decided to split it off into another issue. (I don't have a Mac.)

Tests that involve the network are suspect--our macOS test machines are probably different from upstream's macOS environments, and networking in particular can be tricky depending on the lab. Maybe I just got very unlucky, or maybe macOS needs retries like Windows.

If we can't figure this out for 1.24, we can consider removing the un-CI-tested macOS buildandpack jobs.

@dagood dagood added the new-platform Support a platform new to the microsoft/go infrastructure label Nov 7, 2024
@gdams
Copy link
Member

gdams commented Jan 15, 2025

I've managed to get this working so I'm going to close this issue. The only remaining task is to enable the arm64 builders once the GoTool package has been upgraded:

# - { os: darwin, arch: arm64, config: devscript }
# - { os: darwin, arch: arm64, config: test }
# - { experiment: darwincrypto, os: darwin, arch: arm64, config: test }
# - { experiment: darwincrypto, os: darwin, arch: arm64, config: test, fips: true }

@gdams gdams closed this as completed Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-platform Support a platform new to the microsoft/go infrastructure
Projects
None yet
Development

No branches or pull requests

2 participants