From d7310899f36df218fe407a4ae6b637a48cd14bf7 Mon Sep 17 00:00:00 2001 From: foxmsft Date: Wed, 15 Jan 2025 12:46:56 +0100 Subject: [PATCH 1/2] Separate PowerToys ZoomIt product name To help maintain the Sysinternals branding in the standalone version. --- src/modules/ZoomIt/ZoomIt/PowerToys/branding.h | 3 +++ src/modules/ZoomIt/ZoomIt/ZoomIt.rc | 5 ++++- src/modules/ZoomIt/ZoomIt/ZoomIt.vcxproj | 12 ++++++------ 3 files changed, 13 insertions(+), 7 deletions(-) create mode 100644 src/modules/ZoomIt/ZoomIt/PowerToys/branding.h diff --git a/src/modules/ZoomIt/ZoomIt/PowerToys/branding.h b/src/modules/ZoomIt/ZoomIt/PowerToys/branding.h new file mode 100644 index 000000000000..b5df0fe64bae --- /dev/null +++ b/src/modules/ZoomIt/ZoomIt/PowerToys/branding.h @@ -0,0 +1,3 @@ +#pragma once + +#define ZOOMIT_PRODUCT_NAME "PowerToys Sysinternals ZoomIt" diff --git a/src/modules/ZoomIt/ZoomIt/ZoomIt.rc b/src/modules/ZoomIt/ZoomIt/ZoomIt.rc index b7310ae5976a..1c3a3babebbb 100644 --- a/src/modules/ZoomIt/ZoomIt/ZoomIt.rc +++ b/src/modules/ZoomIt/ZoomIt/ZoomIt.rc @@ -6,6 +6,9 @@ // so that it works with the standalone ZoomIt build too. #include "version.h" +// Included from $(MSBuildThisFileDirectory)PowerToys, for PowerToys strings. +#include "branding.h" + #define APSTUDIO_READONLY_SYMBOLS ///////////////////////////////////////////////////////////////////////////// // @@ -94,7 +97,7 @@ BEGIN VALUE "InternalName", INTERNAL_NAME VALUE "LegalCopyright", COPYRIGHT_NOTE VALUE "OriginalFilename", ORIGINAL_FILENAME - VALUE "ProductName", "PowerToys Sysinternals ZoomIt" + VALUE "ProductName", ZOOMIT_PRODUCT_NAME VALUE "ProductVersion", PRODUCT_VERSION_STRING END END diff --git a/src/modules/ZoomIt/ZoomIt/ZoomIt.vcxproj b/src/modules/ZoomIt/ZoomIt/ZoomIt.vcxproj index 47801a23b4e2..15d3ac99c45a 100644 --- a/src/modules/ZoomIt/ZoomIt/ZoomIt.vcxproj +++ b/src/modules/ZoomIt/ZoomIt/ZoomIt.vcxproj @@ -87,7 +87,7 @@ NDEBUG;_M_IX86;%(PreprocessorDefinitions) 0x0409 - $(MSBuildThisFileDirectory)..\..\..\common\version;$(InterPlatformDir) + $(MSBuildThisFileDirectory)..\..\..\common\version;$(MSBuildThisFileDirectory)PowerToys;$(InterPlatformDir) Shlwapi.lib;comctl32.lib;odbc32.lib;odbccp32.lib;version.lib;Winmm.lib;gdiplus.lib;Msimg32.lib;%(AdditionalDependencies) @@ -109,7 +109,7 @@ NDEBUG;_M_X64;%(PreprocessorDefinitions) 0x0409 - $(MSBuildThisFileDirectory)..\..\..\common\version + $(MSBuildThisFileDirectory)..\..\..\common\version;$(MSBuildThisFileDirectory)PowerToys; Shlwapi.lib;comctl32.lib;odbc32.lib;odbccp32.lib;version.lib;Winmm.lib;gdiplus.lib;Msimg32.lib;%(AdditionalDependencies) @@ -132,7 +132,7 @@ NDEBUG;_M_ARM64;%(PreprocessorDefinitions) 0x0409 - $(MSBuildThisFileDirectory)..\..\..\common\version + $(MSBuildThisFileDirectory)..\..\..\common\version;$(MSBuildThisFileDirectory)PowerToys; Shlwapi.lib;comctl32.lib;odbc32.lib;odbccp32.lib;version.lib;Winmm.lib;gdiplus.lib;Msimg32.lib;%(AdditionalDependencies) @@ -153,7 +153,7 @@ _DEBUG;_M_IX86;%(PreprocessorDefinitions) 0x0409 - $(MSBuildThisFileDirectory)..\..\..\common\version;$(InterPlatformDir) + $(MSBuildThisFileDirectory)..\..\..\common\version;$(MSBuildThisFileDirectory)PowerToys;$(InterPlatformDir) Shlwapi.lib;comctl32.lib;odbc32.lib;odbccp32.lib;version.lib;Winmm.lib;gdiplus.lib;Msimg32.lib;%(AdditionalDependencies) @@ -174,7 +174,7 @@ _DEBUG;_M_X64;%(PreprocessorDefinitions) 0x0409 - $(MSBuildThisFileDirectory)..\..\..\common\version + $(MSBuildThisFileDirectory)..\..\..\common\version;$(MSBuildThisFileDirectory)PowerToys; Shlwapi.lib;comctl32.lib;odbc32.lib;odbccp32.lib;version.lib;version.lib;Winmm.lib;gdiplus.lib;Msimg32.lib;%(AdditionalDependencies) @@ -196,7 +196,7 @@ _DEBUG;_M_ARM64;%(PreprocessorDefinitions) 0x0409 - $(MSBuildThisFileDirectory)..\..\..\common\version + $(MSBuildThisFileDirectory)..\..\..\common\version;$(MSBuildThisFileDirectory)PowerToys; Shlwapi.lib;comctl32.lib;odbc32.lib;odbccp32.lib;version.lib;Winmm.lib;gdiplus.lib;Msimg32.lib;%(AdditionalDependencies) From 8a730ceebd504dc2d49cb8e083c132edb73631c6 Mon Sep 17 00:00:00 2001 From: foxmsft Date: Wed, 15 Jan 2025 13:51:51 +0100 Subject: [PATCH 2/2] Clarify branding-related includes --- src/modules/ZoomIt/ZoomIt/ZoomIt.rc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/modules/ZoomIt/ZoomIt/ZoomIt.rc b/src/modules/ZoomIt/ZoomIt/ZoomIt.rc index 1c3a3babebbb..c57e0ce94b42 100644 --- a/src/modules/ZoomIt/ZoomIt/ZoomIt.rc +++ b/src/modules/ZoomIt/ZoomIt/ZoomIt.rc @@ -2,11 +2,11 @@ // #include "resource.h" -// Included from $(MSBuildThisFileDirectory)..\..\..\common\version -// so that it works with the standalone ZoomIt build too. +// version.h and branding.h are different in the Sysinternals repository, +// keep the includes as such, here. +// From $(MSBuildThisFileDirectory)..\..\..\common\version #include "version.h" - -// Included from $(MSBuildThisFileDirectory)PowerToys, for PowerToys strings. +// From $(MSBuildThisFileDirectory)PowerToys #include "branding.h" #define APSTUDIO_READONLY_SYMBOLS