-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lipsum_from_seed
missing in 0.9.0
#98
Comments
It looks like this was replaced by |
Also needless API breakage, without even deprecating the function first. I understand that this crate doesn't promise any stable API, but it's not like this would have been a huge effort. EDIT: I hope I don't sound to harsh, I'm very thankful to the maintainer spending his time working on this crate ♥. |
Hey folks! Sorry about causing trouble! @kalkin or @tgross35 would you be up for bringing back a The function was removed as part of #91, which had the goal of removing the dependency on the system randomness and thus allow lipsum to be used in WASM. There was some discussion there with @reknih about different approaches. |
That makes sense about the RNG. Honestly I wouldn't mind just gating the feature behind a |
A feature like that would work for us! It's good as long as there is a way to build |
Yeah, exactly! We can make the flag a default flag so that people can use the old API from 0.8.0. I will probably not get around to this anytime soon — @tgross35, could you create a PR for this? |
…er#98) I introduced the default feature `std` which enables the `rand` package features `std` & `std_rng` for the `thread_rng()` function. This allows user to use the rand package without adding it with the right features to own `Cargo.toml`.
Done. See #99. Feedback welcome. |
…er#98) I introduced the default feature `std` which enables the `rand` package features `std` & `std_rng` for the `thread_rng()` function. This allows user to use the rand package without adding it with the right features to own `Cargo.toml`.
It looks like
lipsum_from_seed
disappeared in 0.9. Is there a way to get this same functionality?The text was updated successfully, but these errors were encountered: