You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since domData.set has been added and the domData.get functionality has been set to set so that we do not have a breaking change, it would be important to add warnings that the next major release will depreciate this feature.
Something like:
staticget(element,name,initialValue){if(!element[METAL_DATA]){element[METAL_DATA]={};}if(!name){returnelement[METAL_DATA];}if(!isDef(element[METAL_DATA][name])&&isDef(initialValue))console.warn('domData: get with the set functionality will be deprecated and removed in the next major releases.');element[METAL_DATA][name]=initialValue;}returnelement[METAL_DATA][name];}
What do you think?
The text was updated successfully, but these errors were encountered:
Hey @diegonvs how we talk it off, being a library no longer maintained maybe not ideal and covers few use cases. In this case it's just showing a warning when you use the set functionality inside get.
I do not think we need to try to automate this, just show a friendly message to the developer 🙂.
Hey guys,
Since
domData.set
has been added and thedomData.get
functionality has been set toset
so that we do not have a breaking change, it would be important to add warnings that the next major release will depreciate this feature.Something like:
What do you think?
The text was updated successfully, but these errors were encountered: