Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSO module permissions must be User.Read.All #24

Open
JohannesRudolph opened this issue Nov 13, 2023 · 1 comment
Open

SSO module permissions must be User.Read.All #24

JohannesRudolph opened this issue Nov 13, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@JohannesRudolph
Copy link
Member

Applying this module vanilla fails because User.Read is not a known MS Graph permission

terraform-azure-meshplatform/modules/meshcloud-sso/module.tf

Line 28 in 23e30c9

id = data.azuread_service_principal.msgraph.app_role_ids["User.Read"]

The correct one seems to be User.Read.All which also matches instructions at https://docs.meshcloud.io/docs/meshstack.identity-provider.html#azure-ad-aad
@JohannesRudolph
Copy link
Member Author

It also seems that type=Scope is not correct, azure portal does not enable granting admin consent in this case. This can be fixed by changing this to type=Role

@felixzieger felixzieger added the bug Something isn't working label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JohannesRudolph @felixzieger