Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where is FadingCircle in android? #79

Open
seanadkinson opened this issue Aug 14, 2017 · 5 comments
Open

Where is FadingCircle in android? #79

seanadkinson opened this issue Aug 14, 2017 · 5 comments

Comments

@seanadkinson
Copy link

Noticed FadingCircle isn't implemented in android... source code only handles FadingCircleAlt. Is that an oversight? If so, I'll send a PR. Thanks

@maxs15
Copy link
Owner

maxs15 commented Aug 15, 2017

Weird, should be working.
Not showing up if you try on the Example app ?

@seanadkinson
Copy link
Author

Didn't open the example app, but you can see in the source code that its not handled:

private Sprite getSprite(String spinnerType) {

@maxs15
Copy link
Owner

maxs15 commented Aug 16, 2017

You're right !
You could send a PR, I'll merge it, thanks @seanadkinson

@jjercx
Copy link

jjercx commented Jun 8, 2018

Hi, I'm trying a Spinner with 'FadingCircle' as type, works on iOS but on Android shows only the square spinner. Is this related?

@xeroxoid
Copy link

xeroxoid commented Dec 6, 2018

Yep, it's still broken on android 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants