Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conform to conan licensing practices #154

Open
Jasper-Ben opened this issue May 19, 2021 · 2 comments
Open

Conform to conan licensing practices #154

Jasper-Ben opened this issue May 19, 2021 · 2 comments

Comments

@Jasper-Ben
Copy link
Contributor

Conan expects a license folder in its projects:

[HOOK - conan-center.py] post_package(): ERROR: [PACKAGE LICENSE (KB-H012)] No 'licenses' folder found in package: /home/jasper/.conan/data/seasocks/1.4.4/_/_/package/ac7e8914e54bce4e93d8fd34e732e8c13c5913f2 (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H012)

We should conform to this standard practice, as demonstrated by the zlib conan package:

    |-- conaninfo.txt
    |-- conanmanifest.txt
    |-- include
    |   |-- zconf.h
    |   `-- zlib.h
    |-- lib
    |   `-- libz.a
    `-- licenses
        `-- LICENSE


@madebr
Copy link
Collaborator

madebr commented May 19, 2021

CMake currently installs the license in share/licenses/Seasocks/LICENSE.

The logs I posted at #144 (comment) were from a built with the conan-center hooks enabled.
I interpret them as rules for accepting recipes in the conan-center repo, not as best practices for install prefixes.
As an example, the conan-center hooks currently disallow a share subfolder, which is common on unices (what's the multiple of unix?).

That being said, I'll add self.copy("LICENSE", dst="licenses") to the conan recipe in #144.
That way, if some script is grepping for licenses for all dependencies, it will be found.

@Jasper-Ben
Copy link
Contributor Author

Would be appreciated. We currently use "plain" CMake but as the person who recently had the glorious task of ensuring license compliance in my companies product, I feel somewhat obligated to spare other developers from the pain of non-standard license declarations 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants